third_party/WebKit/LayoutTests/media/controls-repaint-for-network-change.html - Issue 1417683004: Media controls refer to less magic state.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/controls-repaint-for-network-change.html

Issue 1417683004: Media controls refer to less magic state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: ...because NeedsRebaseline is not a platform type. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>
	philipj_slow 2015/10/28 15:14:01 https://www.chromium.org/blink/coding-style/layout https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... liberato (no reviews please) 2015/10/29 16:10:25 Done. Show quoted text On 2015/10/28 15:14:01, philipj wrote: > https://www.chromium.org/blink/coding-style/layout-test-style-guidelines#TOC-... Done.
	2 <head>

	3 <script src="../resources/run-after-layout-and-paint.js"></script>

	4 <script>

	5

	6 testRunner.waitUntilDone();

	7

	8 function test() {

	9

	10 var video1 = document.getElementById("video1");
	philipj_slow 2015/10/28 15:14:02 You might also use document.querySelectorAll("vide You might also use document.querySelectorAll("video") and then video[0] to save some IDs and lines of code. liberato (no reviews please) 2015/10/29 16:10:25 Done. Show quoted text On 2015/10/28 15:14:02, philipj wrote: > You might also use document.querySelectorAll("video") and then video[0] to save > some IDs and lines of code. Done.
	11 var video2 = document.getElementById("video2");

	12 var video3 = document.getElementById("video3");

	13

	14 runAfterLayoutAndPaint(function() {

	15 window.internals.setMediaElementNetworkState(video1, 0);

	16 window.internals.setMediaElementNetworkState(video2, 0);

	17 window.internals.setMediaElementNetworkState(video3, 0);

	18

	19 // These will cause the play buttons to become enabled, and should

	20 // also cause a repaint.

	21 window.internals.setMediaElementNetworkState(video2, 2);

	22 window.internals.setMediaElementNetworkState(video3, 2);

	23

	24 // This will cause the play button to go back to its original state.

	25 window.internals.setMediaElementNetworkState(video3, 0);

	26

	27 testRunner.notifyDone();

	28 });

	29 }

	30 </script>

	31 </head>

	32

	33 <body onload="test()">

	34 <video id="video1" controls></video>

	35 <video id="video2" controls></video>

	36 <video id="video3" controls></video>

	37 <p>Test that network state transitions paint video controls properly.</p>
	philipj_slow 2015/10/28 15:14:01 Is it not possible to write a reliable test using Is it not possible to write a reliable test using the original repro steps that does not need to use a new internal API? liberato (no reviews please) 2015/10/29 16:10:25 not that i could find. it seems to be an actual r Show quoted text On 2015/10/28 15:14:01, philipj wrote: > Is it not possible to write a reliable test using the original repro steps that > does not need to use a new internal API? not that i could find. it seems to be an actual race on when the network state changes, and when the most recent paint was.
	38 </body>

	39

	40 </html>

OLD	NEW