Issue 14175017: Remove one-click signin inforbar, since its now replaced with the gaia

Issue 14175017: Remove one-click signin inforbar, since its now replaced with the gaia (Closed)

Created:
7 years, 8 months ago by Roger Tawa OOO till Jul 10th

Modified:
7 years, 8 months ago

Reviewers:
sail, SteveT, Peter Kasting, Ben Goodger (Google)

CC:
chromium-reviews, akalin, Raghu Simha, kkania, robertshield, oshima+watch_chromium.org, tfarina, haitaol1, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove one-click signin inforbar, since its now replaced with the gaia interstitial page. BUG=233003 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196461

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : Remove field trial #

Patch Set 4 : Fix compile error mac/linux #

Patch Set 5 : Address review comments #

Patch Set 6 : rebased #

Patch Set 7 : Fix merge problem #

Patch Set 8 : rebased #

Patch Set 9 : fix merge, make ctor explicit #

Patch Set 10 : rebased #

Patch Set 11 : rebased #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -486 lines)			Patch
M	chrome/app/chromium_strings.grd	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/app/generated_resources.grd	View		1 chunk	+0 lines, -7 lines	0 comments	Download
M	chrome/app/google_chrome_strings.grd	View	1 2 3 4 5 6 7	1 chunk	+0 lines, -3 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/common/infobar_sync.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_100_percent/infobar_sync.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/common/infobar_sync.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	chrome/app/theme/default_200_percent/infobar_sync.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/app/theme/theme_resources.grd	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/app/theme/touch_100_percent/infobar_sync.png	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/chrome_browser_field_trials_desktop.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/infobars/infobar_delegate.h	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.h	View	1 2 3 4 5	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/sync/one_click_signin_helper.cc	View	1 2 3 4 5 6 7 8 9	5 chunks	+1 line, -199 lines	0 comments	Download
D	chrome/browser/ui/sync/one_click_signin_infobar_delegate.h	View		1 chunk	+0 lines, -48 lines	0 comments	Download
D	chrome/browser/ui/sync/one_click_signin_infobar_delegate.cc	View		1 chunk	+0 lines, -18 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/confirm_infobar.h	View	1 2 3 4 5 6 7 8 9	2 chunks	+1 line, -7 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_background.h	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_background.cc	View	1 2 3 4	1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/infobar_view.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+1 line, -3 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/one_click_signin_infobar.h	View	1 2 3 4	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/ui/views/infobars/one_click_signin_infobar.cc	View	1 2 3 4 5 6 7 8 9	1 chunk	+0 lines, -146 lines	0 comments	Download
M	chrome/browser/ui/views/infobars/translate_infobar_base.cc	View	1 2 3 4	2 chunks	+1 line, -3 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4 5 6 7 8 9	3 chunks	+0 lines, -8 lines	0 comments	Download