Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1258)

Unified Diff: chrome/browser/android/compositor/compositor_view.cc

Issue 1417353003: Move UrlBar background drawing to CC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix yusofo's nit Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/compositor/compositor_view.cc
diff --git a/chrome/browser/android/compositor/compositor_view.cc b/chrome/browser/android/compositor/compositor_view.cc
index 98cba5074fc8eff25e6d007060c99b1b0086d594..23446ce28362aa4821e2b993eb5e67d6de762317 100644
--- a/chrome/browser/android/compositor/compositor_view.cc
+++ b/chrome/browser/android/compositor/compositor_view.cc
@@ -84,7 +84,6 @@ CompositorView::CompositorView(JNIEnv* env,
tab_content_manager_(tab_content_manager),
root_layer_(
cc::SolidColorLayer::Create(content::Compositor::LayerSettings())),
- toolbar_layer_(ToolbarLayer::Create()),
scene_layer_(nullptr),
current_surface_format_(0),
content_width_(0),
@@ -97,6 +96,8 @@ CompositorView::CompositorView(JNIEnv* env,
obj_.Reset(env, obj);
compositor_.reset(content::Compositor::Create(this, window_android));
+ toolbar_layer_ = ToolbarLayer::Create(&(compositor_->GetResourceManager()));
+
root_layer_->SetIsDrawable(true);
root_layer_->SetBackgroundColor(SK_ColorWHITE);
@@ -249,6 +250,8 @@ void CompositorView::UpdateToolbarLayer(JNIEnv* env,
jobject object,
jint toolbar_resource_id,
jint toolbar_background_color,
+ jint url_bar_resource_id,
+ jfloat url_bar_alpha,
jfloat top_offset,
jfloat brightness,
bool visible,
@@ -264,7 +267,8 @@ void CompositorView::UpdateToolbarLayer(JNIEnv* env,
if (visible) {
toolbar_layer_->layer()->SetPosition(gfx::PointF(0, top_offset));
toolbar_layer_->PushResource(resource, toolbar_background_color, false,
- SK_ColorWHITE, false, brightness);
+ SK_ColorWHITE, url_bar_resource_id,
+ url_bar_alpha, false, brightness);
// If we're at rest, hide the shadow. The Android view should be drawing.
toolbar_layer_->layer()->SetMasksToBounds(top_offset >= 0.f

Powered by Google App Engine
This is Rietveld 408576698