Fix ARM integrated assembler to be able to compile spec2k examples.

Fix ARM integrated assembler to be able to compile spec2k examples.

Fixes a couple of bugs that stopped the ARM integrated assembler from
generating assembly code for any spec2k examples.

Fixes are:

1) Handle conditional branches with no else branch.

2) Fix usage of fixups so that the emit method does any needed buffer
lookups. This fixes case where textual fixups (with zero length)
appear at the end of the assembly file.


BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e4289e23cd226f487ef767a59c96e6c77073309a

[Karl, 2015-10-27 19:07:36]

Description was changed from

==========
Fix ARM integrated assembler to be able to compile spec2k examples.

Fixes a couple of bugs that stopped the ARM integrated assembler from
generating assembly code for any spec2k examples.

Fixes are:

1) Handle conditional branches with no else branch.

2) Fix usage of fixups so that the emit method does any needed buffer
lookups. This fixes case where textual fixups (with zero length)
appear at the end of the assembly file.


BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
==========

to

==========
Fix ARM integrated assembler to be able to compile spec2k examples.

Fixes a couple of bugs that stopped the ARM integrated assembler from
generating assembly code for any spec2k examples.

Fixes are:

1) Handle conditional branches with no else branch.

2) Fix usage of fixups so that the emit method does any needed buffer
lookups. This fixes case where textual fixups (with zero length)
appear at the end of the assembly file.


BUG= https://code.google.com/p/nativeclient/issues/detail?id=4334
==========

[Karl, 2015-10-27 19:07:36]

kschimpf@google.com changed reviewers:
+ jpp@chromium.org, sehr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-10-27 21:41:21]

lgtm

https://codereview.chromium.org/1417173003/diff/1/src/IceAssembler.h
File src/IceAssembler.h (right):

https://codereview.chromium.org/1417173003/diff/1/src/IceAssembler.h#newcode290
src/IceAssembler.h:290: /// Returns the value of the given type in the
corresponding buffer.
I would say "Return" instead of "Returns" for agreement with the nearby
comments.

https://codereview.chromium.org/1417173003/diff/1/src/IceFixups.h
File src/IceFixups.h (right):

https://codereview.chromium.org/1417173003/diff/1/src/IceFixups.h#newcode22
src/IceFixups.h:22: class Assembler;
Is this forward declaration needed?  It's already declared in IceDefs.h.

[Karl, 2015-10-27 22:16:31]

Committed patchset #2 (id:20001) manually as
e4289e23cd226f487ef767a59c96e6c77073309a (presubmit successful).

[Karl, 2015-10-27 22:16:42]

https://chromiumcodereview.appspot.com/1417173003/diff/1/src/IceAssembler.h
File src/IceAssembler.h (right):

https://chromiumcodereview.appspot.com/1417173003/diff/1/src/IceAssembler.h#n...
src/IceAssembler.h:290: /// Returns the value of the given type in the
corresponding buffer.
On 2015/10/27 21:41:21, stichnot wrote:
> I would say "Return" instead of "Returns" for agreement with the nearby
> comments.

Done.

https://chromiumcodereview.appspot.com/1417173003/diff/1/src/IceFixups.h
File src/IceFixups.h (right):

https://chromiumcodereview.appspot.com/1417173003/diff/1/src/IceFixups.h#newc...
src/IceFixups.h:22: class Assembler;
On 2015/10/27 21:41:21, stichnot wrote:
> Is this forward declaration needed?  It's already declared in IceDefs.h.

Done.