Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14169010: Remove support for ClientOAuth from GaiaAuthFetcher. (Closed)

Created:
7 years, 8 months ago by Roger Tawa OOO till Jul 10th
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Remove support for ClientOAuth from GaiaAuthFetcher. BUG=92948 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197056

Patch Set 1 #

Patch Set 2 : Fix GoogleServiceAuthError #

Patch Set 3 : rebased #

Patch Set 4 : Fix test break #

Patch Set 5 : rebased #

Patch Set 6 : rebased #

Patch Set 7 : Remove string member #

Patch Set 8 : rebased #

Patch Set 9 : rebased #

Patch Set 10 : rebased #

Patch Set 11 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -701 lines) Patch
M chrome/browser/sync/test/integration/sync_test.cc View 1 2 3 4 1 chunk +0 lines, -11 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.h View 5 chunks +0 lines, -53 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher.cc View 7 chunks +0 lines, -218 lines 0 comments Download
M google_apis/gaia/gaia_auth_fetcher_unittest.cc View 1 2 3 4 chunks +0 lines, -230 lines 0 comments Download
M google_apis/gaia/gaia_constants.h View 1 chunk +1 line, -12 lines 0 comments Download
M google_apis/gaia/gaia_constants.cc View 1 chunk +1 line, -38 lines 0 comments Download
M google_apis/gaia/gaia_urls.h View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -2 lines 0 comments Download
M google_apis/gaia/gaia_urls.cc View 1 2 3 4 5 6 7 8 9 2 chunks +0 lines, -5 lines 0 comments Download
M google_apis/gaia/google_service_auth_error.h View 1 1 chunk +0 lines, -20 lines 0 comments Download
M google_apis/gaia/google_service_auth_error.cc View 1 1 chunk +0 lines, -43 lines 0 comments Download
M google_apis/gaia/google_service_auth_error_unittest.cc View 1 1 chunk +0 lines, -69 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Roger Tawa OOO till Jul 10th
Hi Tim, Please take a look. More code removal. Thanks.
7 years, 8 months ago (2013-04-24 19:30:54 UTC) #1
tim (not reviewing)
LGTM!
7 years, 8 months ago (2013-04-26 16:34:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/14169010/53003
7 years, 8 months ago (2013-04-26 17:45:28 UTC) #3
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-26 17:46:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/14169010/53003
7 years, 8 months ago (2013-04-26 17:51:25 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=107562
7 years, 8 months ago (2013-04-26 20:42:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/14169010/53003
7 years, 8 months ago (2013-04-26 23:55:15 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=107892
7 years, 8 months ago (2013-04-27 01:19:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/14169010/127001
7 years, 7 months ago (2013-04-29 13:59:27 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-04-29 16:39:05 UTC) #10
Message was sent while issue was closed. 
Change committed as 197056

Powered by Google App Engine
This is Rietveld 408576698