Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 14169006: roll clang 176256:179138 (Closed)

Created:
7 years, 8 months ago by Nico
Modified:
7 years, 8 months ago
CC:
chromium-reviews, eugenis+clang_chromium.org, dmikurube+clang_chromium.org, glider+clang_chromium.org, glotov+watch_chromium.org, ukai+watch_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : cros32 #

Patch Set 3 : cros main waterfall #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M build/common.gypi View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M tools/clang/scripts/update.sh View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 14 (0 generated)
Nico
7 years, 8 months ago (2013-04-19 15:29:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14169006/1
7 years, 8 months ago (2013-04-19 15:29:48 UTC) #2
commit-bot: I haz the power
Change committed as 195220
7 years, 8 months ago (2013-04-19 17:38:22 UTC) #3
Nico
This broke 32bit linux builds. I think I added a workaround for that, so I'm ...
7 years, 8 months ago (2013-04-19 22:13:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14169006/18001
7 years, 8 months ago (2013-04-19 22:14:10 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=8630
7 years, 8 months ago (2013-04-20 02:43:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/14169006/18001
7 years, 8 months ago (2013-04-20 04:34:53 UTC) #7
commit-bot: I haz the power
Change committed as 195379
7 years, 8 months ago (2013-04-20 04:38:05 UTC) #8
Nico
+glider to look at the build/common.gypi changes
7 years, 8 months ago (2013-04-22 22:45:02 UTC) #9
Nico
Committed patchset #3 manually as r195632 (presubmit successful).
7 years, 8 months ago (2013-04-22 22:51:41 UTC) #10
Alexander Potapenko
Thanks for looking into this! On Tue, Apr 23, 2013 at 2:51 AM, <thakis@chromium.org> wrote: ...
7 years, 8 months ago (2013-04-23 09:03:49 UTC) #11
Dan Beam
https://codereview.chromium.org/14169006/diff/35001/tools/clang/scripts/update.sh File tools/clang/scripts/update.sh (right): https://codereview.chromium.org/14169006/diff/35001/tools/clang/scripts/update.sh#newcode11 tools/clang/scripts/update.sh:11: CLANG_REVISION=179138 I'm unable to build after this roll. I ...
7 years, 8 months ago (2013-04-24 00:23:42 UTC) #12
Nico
You probably have multiple chrome checkouts, are using goma, have clang from one checkout in ...
7 years, 8 months ago (2013-04-24 00:26:57 UTC) #13
Dan Beam
7 years, 8 months ago (2013-04-24 00:32:58 UTC) #14
Message was sent while issue was closed.
On 2013/04/24 00:26:57, Nico wrote:
> You probably have multiple chrome checkouts, are using goma, have clang
> from one checkout in your path, and are using it in a different checkout
> where you haven't updated clang yet.

Great guess :), thanks for the help.  I'll be back if not the case (but
unlikely).

Thanks dude,

Dan

> 
> 
> On Tue, Apr 23, 2013 at 5:23 PM, <mailto:dbeam@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.**org/14169006/diff/35001/tools/**
> >
>
clang/scripts/update.sh<https://codereview.chromium.org/14169006/diff/35001/tools/clang/scripts/update.sh>
> > File tools/clang/scripts/update.sh (right):
> >
> > https://codereview.chromium.**org/14169006/diff/35001/tools/**
> >
>
clang/scripts/update.sh#**newcode11<https://codereview.chromium.org/14169006/diff/35001/tools/clang/scripts/update.sh#newcode11>
> > tools/clang/scripts/update.sh:**11: CLANG_REVISION=179138
> > I'm unable to build after this roll. I don't know if others are having
> > similar issues. Stack:
> > https://gist.github.com/**danbeam/de20b813b3049b04ede2/**raw/**
> >
>
b8b1324e32e24d8d5aa6ab1359ce53**48efd77ceb/clang-borked.txt<https://gist.github.com/danbeam/de20b813b3049b04ede2/raw/b8b1324e32e24d8d5aa6ab1359ce5348efd77ceb/clang-borked.txt>
> >
> >
>
https://codereview.chromium.**org/14169006/%3Chttps://codereview.chromium.org...>
> >

Powered by Google App Engine
This is Rietveld 408576698