Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 14166006: Including touchscreen events report in feedback (Closed)

Created:
7 years, 8 months ago by Yufeng Shen (Slow to review)
Modified:
7 years, 8 months ago
Reviewers:
rkc
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Including touchscreen events report in feedback I think when we migrate from using src/platform/userfeedback/etc/sys_log_utils.sysinfo.lst to hard-coded entries in command_line_log_source.cc we missed the entry for collecting touchscreen events. This patch adds it back. BUG=234237 TEST=1. Go chrome://system, check entry exists hack-33025-touchscreen_activity 2. File a feedback, and check that the above entry is in the feedback report. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195624

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M chrome/browser/chromeos/system_logs/command_line_log_source.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yufeng Shen (Slow to review)
7 years, 8 months ago (2013-04-22 20:14:55 UTC) #1
rkc
LGTM - though considering the number of touch relaged logs now, you should consider creating ...
7 years, 8 months ago (2013-04-22 20:18:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miletus@chromium.org/14166006/1
7 years, 8 months ago (2013-04-22 20:29:15 UTC) #3
commit-bot: I haz the power
7 years, 8 months ago (2013-04-22 22:39:12 UTC) #4
Message was sent while issue was closed.
Change committed as 195624

Powered by Google App Engine
This is Rietveld 408576698