Make android_webview_test_apk go a bit farther on Swarming.

Make android_webview_test_apk go a bit farther on Swarming.

This doesn't fix the test completely but it goes up to the instrumentation code.

R=stip@chromium.org
TBR=sgurun@chromium.org
BUG=chromium:525873
Committed: https://crrev.com/56f77ba2c6a0aeade32b69fa94694e641f6bfa1c
Cr-Commit-Position: refs/heads/master@{#357969}

[M-A Ruel, 2015-11-04 21:02:27]

With this it goes much farther but still fails;
https://chromium-swarm-dev.appspot.com/user/task/2aed15a8adbb7b10

I'd still prefer to commit this since it's definitely needed, just not complete
yet as I've hit the wall of what I understand at that point.

[ghost stip (do not use), 2015-11-04 21:10:25]

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
File android_webview/android_webview_test_apk_run.isolate (right):

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
android_webview/android_webview_test_apk_run.isolate:10:
'<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
you'll need to change this to be like
https://chromium.googlesource.com/chromium/src/+/master/chrome/android/chrome...,
specifically

    'command': [
      '<(PRODUCT_DIR)/bin/run_chrome_public_test_apk',
      '--enable-platform-mode',
      '-e', 'local', '--apk-under-test',
      '<(PRODUCT_DIR)/apks/ChromePublic.apk',

[jbudorick, 2015-11-04 21:11:38]

jbudorick@chromium.org changed reviewers:
+ jbudorick@chromium.org

[jbudorick, 2015-11-04 21:11:39]

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
File android_webview/android_webview_test_apk_run.isolate (right):

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
android_webview/android_webview_test_apk_run.isolate:10:
'<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
On 2015/11/04 21:10:25, stip wrote:
> you'll need to change this to be like
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/android/chrome...,
> specifically
> 
>     'command': [
>       '<(PRODUCT_DIR)/bin/run_chrome_public_test_apk',
>       '--enable-platform-mode',
>       '-e', 'local', '--apk-under-test',
>       '<(PRODUCT_DIR)/apks/ChromePublic.apk',

yay transition states

[M-A Ruel, 2015-11-04 21:13:14]

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
File android_webview/android_webview_test_apk_run.isolate (right):

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
android_webview/android_webview_test_apk_run.isolate:10:
'<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
On 2015/11/04 21:10:25, stip wrote:
> you'll need to change this to be like
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/android/chrome...,
> specifically
> 
>     'command': [
>       '<(PRODUCT_DIR)/bin/run_chrome_public_test_apk',
>       '--enable-platform-mode',
>       '-e', 'local', '--apk-under-test',
>       '<(PRODUCT_DIR)/apks/ChromePublic.apk',

This doesn't make sense:
~/src/chromium.android/src> ls out/Release/apks
AndroidWebView.apk  AndroidWebViewTest.apk  OnDeviceInstrumentationDriver.apk 
remote_device_dummy.apk

ChromePublic.apk is not built.

[M-A Ruel, 2015-11-04 21:16:29]

On 2015/11/04 21:13:14, M-A Ruel wrote:
>
https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
> File android_webview/android_webview_test_apk_run.isolate (right):
> 
>
https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
> android_webview/android_webview_test_apk_run.isolate:10:
> '<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
> On 2015/11/04 21:10:25, stip wrote:
> > you'll need to change this to be like
> >
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/android/chrome...,
> > specifically
> > 
> >     'command': [
> >       '<(PRODUCT_DIR)/bin/run_chrome_public_test_apk',
> >       '--enable-platform-mode',
> >       '-e', 'local', '--apk-under-test',
> >       '<(PRODUCT_DIR)/apks/ChromePublic.apk',
> 
> This doesn't make sense:
> ~/src/chromium.android/src> ls out/Release/apks
> AndroidWebView.apk  AndroidWebViewTest.apk  OnDeviceInstrumentationDriver.apk 
> remote_device_dummy.apk
> 
> ChromePublic.apk is not built.

and I can't run it at the moment due to lighttpd not installed locally.

[jbudorick, 2015-11-04 21:44:09]

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
File android_webview/android_webview_test_apk_run.isolate (right):

https://chromiumcodereview.appspot.com/1416373008/diff/1/android_webview/andr...
android_webview/android_webview_test_apk_run.isolate:10:
'<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
On 2015/11/04 21:13:14, M-A Ruel wrote:
> On 2015/11/04 21:10:25, stip wrote:
> > you'll need to change this to be like
> >
>
https://chromium.googlesource.com/chromium/src/+/master/chrome/android/chrome...,
> > specifically
> > 
> >     'command': [
> >       '<(PRODUCT_DIR)/bin/run_chrome_public_test_apk',
> >       '--enable-platform-mode',
> >       '-e', 'local', '--apk-under-test',
> >       '<(PRODUCT_DIR)/apks/ChromePublic.apk',
> 
> This doesn't make sense:
> ~/src/chromium.android/src> ls out/Release/apks
> AndroidWebView.apk  AndroidWebViewTest.apk  OnDeviceInstrumentationDriver.apk 
> remote_device_dummy.apk
> 
> ChromePublic.apk is not built.

it should be

  '<(PRODUCT_DIR)/bin/run_android_webview_test_apk',
  '--enable-platform-mode', '-e', 'local',
  '--apk-under-test', '<(PRODUCT_DIR)/apks/AndroidWebView.apk'

[ghost stip (do not use), 2015-11-04 21:51:15]

M-A, I'm writing the CL to fix it now

[M-A Ruel, 2015-11-04 21:53:17]

On 2015/11/04 21:51:15, stip wrote:
> M-A, I'm writing the CL to fix it now

Patchset #2 is running as
https://chromium-swarm-dev.appspot.com/user/task/2aed491511a5ad10

I'M WAITING FOR AN OUTPUT. :D

[M-A Ruel, 2015-11-04 22:17:49]

On 2015/11/04 21:53:17, M-A Ruel wrote:
> On 2015/11/04 21:51:15, stip wrote:
> > M-A, I'm writing the CL to fix it now
> 
> Patchset #2 is running as
> https://chromium-swarm-dev.appspot.com/user/task/2aed491511a5ad10
> 
> I'M WAITING FOR AN OUTPUT. :D

I had to try again with a proper bot;
https://chromium-swarm-dev.appspot.com/user/task/2aed5f0354ec5910 and it
succeeded. Good to go?

[jbudorick, 2015-11-04 22:18:22]

On 2015/11/04 22:17:49, M-A Ruel wrote:
> On 2015/11/04 21:53:17, M-A Ruel wrote:
> > On 2015/11/04 21:51:15, stip wrote:
> > > M-A, I'm writing the CL to fix it now
> > 
> > Patchset #2 is running as
> > https://chromium-swarm-dev.appspot.com/user/task/2aed491511a5ad10
> > 
> > I'M WAITING FOR AN OUTPUT. :D
> 
> I had to try again with a proper bot;
> https://chromium-swarm-dev.appspot.com/user/task/2aed5f0354ec5910 and it
> succeeded. Good to go?

lgtm

[M-A Ruel, 2015-11-04 22:18:55]

The CQ bit was checked by maruel@chromium.org

[commit-bot: I haz the power, 2015-11-04 22:19:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416373008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416373008/20001

[commit-bot: I haz the power, 2015-11-04 22:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-11-04 22:47:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ghost stip (do not use), 2015-11-05 00:15:20]

Description was changed from

==========
Make android_webview_test_apk go a bit farther on Swarming.

This doesn't fix the test completely but it goes up to the instrumentation code.

R=stip@chromium.org
BUG=chromium:525873
==========

to

==========
Make android_webview_test_apk go a bit farther on Swarming.

This doesn't fix the test completely but it goes up to the instrumentation code.

R=stip@chromium.org
TBR=sgurun@chromium.org 
BUG=chromium:525873
==========

[ghost stip (do not use), 2015-11-05 00:15:20]

stip@chromium.org changed reviewers:
+ sgurun@chromium.org

[ghost stip (do not use), 2015-11-05 00:15:32]

+sgurun@chromium.org

[ghost stip (do not use), 2015-11-05 00:18:42]

The CQ bit was checked by stip@chromium.org

[commit-bot: I haz the power, 2015-11-05 00:20:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1416373008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1416373008/20001

[commit-bot: I haz the power, 2015-11-05 01:22:45]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-11-05 01:24:14]

Patchset 2 (id:??) landed as
https://crrev.com/56f77ba2c6a0aeade32b69fa94694e641f6bfa1c
Cr-Commit-Position: refs/heads/master@{#357969}