Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 1416093004: Remove CustomTab and have all CustomTabActivity using Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed clang build error Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
index aad2ddc5641c620711b6d3953eee2abc1020454f..ce6dbcafb282db2b2b5ff36c878726ec8fb944b5 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
@@ -16,6 +16,7 @@ import org.chromium.chrome.browser.UrlUtilities;
import org.chromium.chrome.browser.WarmupManager;
import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;
import org.chromium.chrome.browser.tab.Tab;
+import org.chromium.chrome.browser.tab.TabDelegateFactory;
import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;
import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParamsManager;
@@ -115,6 +116,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
boolean openInForeground = mOrderController.willOpenInForeground(type, mIncognito)
|| webContents != null;
+ TabDelegateFactory delegateFactory = new TabDelegateFactory();
Tab tab;
if (webContents != null) {
// A WebContents was passed through the Intent. Create a new Tab to hold it.
@@ -127,7 +129,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
== TabModel.INVALID_TAB_INDEX;
tab = Tab.createLiveTab(assignedTabId, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
- tab.initialize(webContents, mTabContentManager, !openInForeground);
+ tab.initialize(webContents, mTabContentManager, delegateFactory, !openInForeground);
tab.setParentIntent(parentIntent);
webContents.resumeLoadingCreatedWebContents();
} else if (!openInForeground && SysUtils.isLowEndDevice()) {
@@ -136,7 +138,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
// tab.
tab = Tab.createTabForLazyLoad(mActivity, mIncognito, mNativeWindow, type,
parentId, loadUrlParams);
- tab.initialize(null, mTabContentManager, !openInForeground);
+ tab.initialize(null, mTabContentManager, delegateFactory, !openInForeground);
mTabSaver.addTabToSaveQueue(tab);
} else {
webContents =
@@ -145,7 +147,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
- tab.initialize(webContents, mTabContentManager, !openInForeground);
+ tab.initialize(webContents, mTabContentManager, delegateFactory, !openInForeground);
tab.loadUrl(loadUrlParams);
}
tab.getTabRedirectHandler().updateIntent(intent);
@@ -177,7 +179,8 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
boolean openInForeground = mOrderController.willOpenInForeground(type, mIncognito);
Tab tab = Tab.createLiveTab(Tab.INVALID_TAB_ID, mActivity, mIncognito,
mNativeWindow, type, parentId, !openInForeground);
- tab.initialize(webContents, mTabContentManager, !openInForeground);
+ tab.initialize(
+ webContents, mTabContentManager, new TabDelegateFactory(), !openInForeground);
mTabModel.addTab(tab, position, type);
return true;
}
@@ -270,7 +273,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {
id, mActivity, state.isIncognito(), mNativeWindow, state.parentId, state);
boolean selectTab = mOrderController.willOpenInForeground(TabLaunchType.FROM_RESTORE,
state.isIncognito());
- tab.initialize(null, mTabContentManager, !selectTab);
+ tab.initialize(null, mTabContentManager, new TabDelegateFactory(), !selectTab);
assert state.isIncognito() == mIncognito;
mTabModel.addTab(tab, index, TabLaunchType.FROM_RESTORE);
return tab;

Powered by Google App Engine
This is Rietveld 408576698