chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java - Issue 1416093004: Remove CustomTab and have all CustomTabActivity using Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

Issue 1416093004: Remove CustomTab and have all CustomTabActivity using Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed clang build error Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTab.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenDelegateFactory.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

index 0e8e689a46e4132fe352e8026c9d18fd49c6f033..0dda815e9bd2cc90ef7f13c143bcc8a3a16c9142 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

@@ -71,7 +71,6 @@ import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchFieldTrial;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchManager;

import org.chromium.chrome.browser.contextualsearch.ContextualSearchManager.ContextualSearchTabPromotionDelegate;

-import org.chromium.chrome.browser.customtabs.CustomTab;

import org.chromium.chrome.browser.device.DeviceClassManager;

import org.chromium.chrome.browser.dom_distiller.DistilledPagePrefsView;

import org.chromium.chrome.browser.dom_distiller.ReaderModeActivityDelegate;

@@ -631,7 +630,7 @@ public abstract class ChromeActivity extends AsyncInitializationActivity

}

/**

- * @return Whether the given activity contains a {@link CustomTab}.

+ * @return Whether the given activity contains a CustomTab.

public boolean isCustomTab() {

return false;