Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 14160002: Add HasChangeListKind and HasFileListKind methods. (Closed)

Created:
7 years, 8 months ago by hidehiko
Modified:
7 years, 8 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Add HasChangeListKind and HasFileListKind methods. New methods will be used to figure out what is the returned JSON's type in following CL. BUG=224870 TEST=Ran unit_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193642

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -4 lines) Patch
M chrome/browser/google_apis/drive_api_parser.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/drive_api_parser.cc View 2 chunks +12 lines, -4 lines 0 comments Download
M chrome/browser/google_apis/drive_api_parser_unittest.cc View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 8 months ago (2013-04-11 08:05:43 UTC) #1
kinaba
lgtm
7 years, 8 months ago (2013-04-11 08:12:36 UTC) #2
hidehiko
On 2013/04/11 08:12:36, kinaba wrote: > lgtm Oops... I thought I built the code and ...
7 years, 8 months ago (2013-04-11 08:15:52 UTC) #3
hidehiko
On 2013/04/11 08:15:52, hidehiko wrote: > On 2013/04/11 08:12:36, kinaba wrote: > > lgtm > ...
7 years, 8 months ago (2013-04-11 08:22:33 UTC) #4
kinaba
Oops, should have noticed this while reviewing, sorry. lgtm (assuming it compiles and passes tests)
7 years, 8 months ago (2013-04-11 08:28:08 UTC) #5
hashimoto
lgtm
7 years, 8 months ago (2013-04-11 08:28:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/14160002/4001
7 years, 8 months ago (2013-04-11 08:29:43 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-11 09:00:52 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hidehiko@chromium.org/14160002/4001
7 years, 8 months ago (2013-04-11 12:42:00 UTC) #9
commit-bot: I haz the power
7 years, 8 months ago (2013-04-11 14:37:39 UTC) #10
Message was sent while issue was closed.
Change committed as 193642

Powered by Google App Engine
This is Rietveld 408576698