Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 14156007: Remove WebSecurityOrigin from chromium (Closed)

Created:
7 years, 8 months ago by alecflett
Modified:
7 years, 8 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Remove WebSecurityOrigin from chromium This is part 2 of 3. WebFrame and WebSecurityOrigin is now gone from the backend. BUG=233361 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196450

Patch Set 1 #

Patch Set 2 : Fix missing test #

Patch Set 3 : Remove WebFrame check removal #

Total comments: 3

Patch Set 4 : clean up inconsistent naming #

Patch Set 5 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -102 lines) Patch
M content/browser/in_process_webkit/indexed_db_dispatcher_host.cc View 4 chunks +6 lines, -9 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 2 chunks +3 lines, -14 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 1 2 3 chunks +6 lines, -33 lines 0 comments Download
M content/common/indexed_db/indexed_db_messages.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/common/indexed_db/proxy_webidbfactory_impl.h View 1 2 3 3 chunks +3 lines, -7 lines 0 comments Download
M content/common/indexed_db/proxy_webidbfactory_impl.cc View 1 2 3 4 4 chunks +6 lines, -11 lines 0 comments Download
M webkit/support/test_webidbfactory.h View 1 1 chunk +7 lines, -10 lines 0 comments Download
M webkit/support/test_webidbfactory.cc View 1 2 chunks +10 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
alecflett
jsbell - review for indexed_db stuff? tsepez - review for messages? darin - review for ...
7 years, 8 months ago (2013-04-24 03:57:04 UTC) #1
darin (slow to review)
LGTM https://codereview.chromium.org/14156007/diff/5001/content/common/indexed_db/proxy_webidbfactory_impl.cc File content/common/indexed_db/proxy_webidbfactory_impl.cc (right): https://codereview.chromium.org/14156007/diff/5001/content/common/indexed_db/proxy_webidbfactory_impl.cc#newcode27 content/common/indexed_db/proxy_webidbfactory_impl.cc:27: const WebString& databaseIdentifier, nit: ditto https://codereview.chromium.org/14156007/diff/5001/content/common/indexed_db/proxy_webidbfactory_impl.h File content/common/indexed_db/proxy_webidbfactory_impl.h ...
7 years, 8 months ago (2013-04-24 05:42:54 UTC) #2
Tom Sepez
Messages LGTM.
7 years, 8 months ago (2013-04-24 18:53:22 UTC) #3
jsbell
lgtm https://codereview.chromium.org/14156007/diff/5001/content/common/indexed_db/proxy_webidbfactory_impl.cc File content/common/indexed_db/proxy_webidbfactory_impl.cc (right): https://codereview.chromium.org/14156007/diff/5001/content/common/indexed_db/proxy_webidbfactory_impl.cc#newcode42 content/common/indexed_db/proxy_webidbfactory_impl.cc:42: const WebString& data_dirDebug) { Is this rename intentional?
7 years, 8 months ago (2013-04-24 21:37:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14156007/13001
7 years, 8 months ago (2013-04-25 01:20:20 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-25 01:44:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14156007/13001
7 years, 8 months ago (2013-04-25 03:26:59 UTC) #7
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-25 03:36:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14156007/13001
7 years, 8 months ago (2013-04-25 16:17:11 UTC) #9
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-25 16:27:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14156007/44002
7 years, 8 months ago (2013-04-25 17:23:39 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 8 months ago (2013-04-25 17:25:26 UTC) #12
commit-bot: I haz the power
Failed to apply the patch.
7 years, 8 months ago (2013-04-25 17:54:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alecflett@chromium.org/14156007/44002
7 years, 8 months ago (2013-04-25 18:13:53 UTC) #14
alecflett
7 years, 8 months ago (2013-04-25 19:03:53 UTC) #15
Message was sent while issue was closed.
Committed patchset #5 manually as r196450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698