Add dyncode syscall disabled test

Add dyncode syscall disabled test

Verifies that under PNaCl, the dyncode syscalls are disabled, which removes
this way to control the exposed NaCl text section.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=3109

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196272

[sehr, 2013-04-23 22:14:34]

PTAL.  I need to wait for a commit to the nacl repo and a DEPS roll before
committing, FWIW.

[jvoung (off chromium), 2013-04-23 22:43:27]

some nits, but LGTM

I was also adding a test and it turns out that yz did some refactoring to the
gyp files:
https://codereview.chromium.org/13811036/

So you may have to rebase.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
File chrome/test/data/nacl/nacl_test_data.gyp (right):

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:134: 'enable_x86_32': 0,
Maybe add a comment that these "enable_*: 0" are to stop translating the pexe ->
nexe.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:157:
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
nit: sort this list?

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/pnacl_d...
File
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html
(right):

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/pnacl_d...
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html:38:
width="0" height="0" />
Maybe make the width+height non-zero so that we can see the puzzle piece if for
some reason nacl is disabled.

[bradn, 2013-04-23 22:47:52]

LGTM

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
File chrome/test/data/nacl/nacl_test_data.gyp (right):

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:136: 'enable_arm': 0,
This just landed which will require you to change this slightly:
https://codereview.chromium.org/13811036/

Probably just need to add:
 'nexe_destination_dir': 'nacl_test_data',
 'current_depth': '<(DEPTH)',

And a dependency on:
 '<(DEPTH)/ppapi/ppapi_nacl_test_common.gyp:nacl_test_common',

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:140: '-lppapi',
You probably don't need -lppapi after the rebase.

[sehr, 2013-04-24 15:34:25]

I will watch for YZ to commit his change again, but in the meantime, PTAL.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
File chrome/test/data/nacl/nacl_test_data.gyp (right):

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:134: 'enable_x86_32': 0,
On 2013/04/23 22:43:27, jvoung (cr) wrote:
> Maybe add a comment that these "enable_*: 0" are to stop translating the pexe
->
> nexe.

Done.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:136: 'enable_arm': 0,
On 2013/04/23 22:47:52, bradn wrote:
> This just landed which will require you to change this slightly:
> https://codereview.chromium.org/13811036/
> 
> Probably just need to add:
>  'nexe_destination_dir': 'nacl_test_data',
>  'current_depth': '<(DEPTH)',
> 
> And a dependency on:
>  '<(DEPTH)/ppapi/ppapi_nacl_test_common.gyp:nacl_test_common',

That change was reverted.  So we're racing :-)

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:140: '-lppapi',
On 2013/04/23 22:47:52, bradn wrote:
> You probably don't need -lppapi after the rebase.

Ditto.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/nacl_te...
chrome/test/data/nacl/nacl_test_data.gyp:157:
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
On 2013/04/23 22:43:27, jvoung (cr) wrote:
> nit: sort this list?

Done.

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/pnacl_d...
File
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html
(right):

https://codereview.chromium.org/14154005/diff/1/chrome/test/data/nacl/pnacl_d...
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html:38:
width="0" height="0" />
On 2013/04/23 22:43:27, jvoung (cr) wrote:
> Maybe make the width+height non-zero so that we can see the puzzle piece if
for
> some reason nacl is disabled.

Done.

[commit-bot: I haz the power, 2013-04-24 22:09:20]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sehr@chromium.org/14154005/13001

[commit-bot: I haz the power, 2013-04-24 22:09:23]

Presubmit check for 14154005-13001 failed and returned exit status 1.

INFO:root:Found 4 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    chrome/test/data/nacl/nacl_test_data.gyp
   
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.cc
   
chrome/test/data/nacl/pnacl_dyncode_syscall_disabled/pnacl_dyncode_syscall_disabled.html
    chrome/test/nacl/nacl_browsertest.cc

[bradnelson, 2013-04-24 22:15:06]

LGTM

[commit-bot: I haz the power, 2013-04-24 22:15:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sehr@chromium.org/14154005/13001

[commit-bot: I haz the power, 2013-04-25 00:27:51]

Change committed as 196272