Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1415183010: Fix race in gkvlite introduced when removing `unsafe` (Closed)

Created:
5 years, 1 month ago by iannucci
Modified:
5 years, 1 month ago
Reviewers:
Vadim Sh.
Base URL:
https://chromium.googlesource.com/external/github.com/luci/gkvlite.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix race in gkvlite introduced when removing `unsafe` This is very much a giant hammer approach, but it doesn't seem too bad in terms of performance penalty. We can rip all these hacks out when we're only using managed VMs instead of classic GAE. R=vadimsh@chromium.org BUG= Committed: 107566880ec5e4c0c2ab65c0329a5ebd4f22bd19

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -21 lines) Patch
M node.go View 1 3 chunks +29 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
iannucci
5 years, 1 month ago (2015-11-10 19:10:51 UTC) #1
Vadim Sh.
https://chromiumcodereview.appspot.com/1415183010/diff/1/node.go File node.go (right): https://chromiumcodereview.appspot.com/1415183010/diff/1/node.go#newcode66 node.go:66: nodeLocGL.Unlock() wat? did you forget "defer"? Also you can ...
5 years, 1 month ago (2015-11-10 19:14:06 UTC) #2
iannucci
On 2015/11/10 at 19:14:06, vadimsh wrote: > https://chromiumcodereview.appspot.com/1415183010/diff/1/node.go > File node.go (right): > > https://chromiumcodereview.appspot.com/1415183010/diff/1/node.go#newcode66 ...
5 years, 1 month ago (2015-11-10 20:06:54 UTC) #3
Vadim Sh.
lgtm
5 years, 1 month ago (2015-11-10 20:07:34 UTC) #4
iannucci
5 years, 1 month ago (2015-11-10 20:10:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
107566880ec5e4c0c2ab65c0329a5ebd4f22bd19 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698