Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: src/api.cc

Issue 14149009: Fix debug print and wrong handle dereference in es6 typed array. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects-printer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 605 matching lines...) Expand 10 before | Expand all | Expand 10 after
616 isolate->stack_guard()->SetStackLimit(limit); 616 isolate->stack_guard()->SetStackLimit(limit);
617 } 617 }
618 return true; 618 return true;
619 } 619 }
620 620
621 621
622 i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) { 622 i::Object** V8::GlobalizeReference(i::Isolate* isolate, i::Object** obj) {
623 if (IsDeadCheck(isolate, "V8::Persistent::New")) return NULL; 623 if (IsDeadCheck(isolate, "V8::Persistent::New")) return NULL;
624 LOG_API(isolate, "Persistent::New"); 624 LOG_API(isolate, "Persistent::New");
625 i::Handle<i::Object> result = isolate->global_handles()->Create(*obj); 625 i::Handle<i::Object> result = isolate->global_handles()->Create(*obj);
626 #ifdef DEBUG
627 (*obj)->Verify();
628 #endif // DEBUG
626 return result.location(); 629 return result.location();
627 } 630 }
628 631
629 632
630 void V8::MakeWeak(i::Isolate* isolate, 633 void V8::MakeWeak(i::Isolate* isolate,
631 i::Object** object, 634 i::Object** object,
632 void* parameters, 635 void* parameters,
633 WeakReferenceCallback weak_reference_callback, 636 WeakReferenceCallback weak_reference_callback,
634 NearDeathCallback near_death_callback) { 637 NearDeathCallback near_death_callback) {
635 ASSERT(isolate == i::Isolate::Current()); 638 ASSERT(isolate == i::Isolate::Current());
(...skipping 6742 matching lines...) Expand 10 before | Expand all | Expand 10 after
7378 7381
7379 v->VisitPointers(blocks_.first(), first_block_limit_); 7382 v->VisitPointers(blocks_.first(), first_block_limit_);
7380 7383
7381 for (int i = 1; i < blocks_.length(); i++) { 7384 for (int i = 1; i < blocks_.length(); i++) {
7382 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]); 7385 v->VisitPointers(blocks_[i], &blocks_[i][kHandleBlockSize]);
7383 } 7386 }
7384 } 7387 }
7385 7388
7386 7389
7387 } } // namespace v8::internal 7390 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects-printer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698