Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: third_party/WebKit/Source/core/frame/RemoteFrame.cpp

Issue 1414663011: Notifying the Out of Process Renderer about Visibility Change of a Remote Frame (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed the Call to WebRemoteFrameImpl::close() and WebViewHelper::reset() in the Destructor of the … Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/frame/RemoteFrame.h" 5 #include "core/frame/RemoteFrame.h"
6 6
7 #include "bindings/core/v8/WindowProxy.h" 7 #include "bindings/core/v8/WindowProxy.h"
8 #include "bindings/core/v8/WindowProxyManager.h" 8 #include "bindings/core/v8/WindowProxyManager.h"
9 #include "core/dom/RemoteSecurityContext.h" 9 #include "core/dom/RemoteSecurityContext.h"
10 #include "core/frame/LocalFrame.h" 10 #include "core/frame/LocalFrame.h"
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 void RemoteFrame::forwardInputEvent(Event* event) 138 void RemoteFrame::forwardInputEvent(Event* event)
139 { 139 {
140 remoteFrameClient()->forwardInputEvent(event); 140 remoteFrameClient()->forwardInputEvent(event);
141 } 141 }
142 142
143 void RemoteFrame::frameRectsChanged(const IntRect& frameRect) 143 void RemoteFrame::frameRectsChanged(const IntRect& frameRect)
144 { 144 {
145 remoteFrameClient()->frameRectsChanged(frameRect); 145 remoteFrameClient()->frameRectsChanged(frameRect);
146 } 146 }
147 147
148 void RemoteFrame::visibilityChanged(bool visible)
149 {
150 if (remoteFrameClient())
151 remoteFrameClient()->visibilityChanged(visible);
152 }
153
148 void RemoteFrame::setView(PassRefPtrWillBeRawPtr<RemoteFrameView> view) 154 void RemoteFrame::setView(PassRefPtrWillBeRawPtr<RemoteFrameView> view)
149 { 155 {
150 // Oilpan: as RemoteFrameView performs no finalization actions, 156 // Oilpan: as RemoteFrameView performs no finalization actions,
151 // no explicit dispose() of it needed here. (cf. FrameView::dispose().) 157 // no explicit dispose() of it needed here. (cf. FrameView::dispose().)
152 m_view = view; 158 m_view = view;
153 159
154 // ... the RemoteDOMWindow will need to be informed of detachment, 160 // ... the RemoteDOMWindow will need to be informed of detachment,
155 // as otherwise it will keep a strong reference back to this RemoteFrame. 161 // as otherwise it will keep a strong reference back to this RemoteFrame.
156 // That combined with wrappers (owned and kept alive by RemoteFrame) keeping 162 // That combined with wrappers (owned and kept alive by RemoteFrame) keeping
157 // persistent strong references to RemoteDOMWindow will prevent the GCing 163 // persistent strong references to RemoteDOMWindow will prevent the GCing
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 ASSERT(owner()); 197 ASSERT(owner());
192 toHTMLFrameOwnerElement(owner())->setNeedsCompositingUpdate(); 198 toHTMLFrameOwnerElement(owner())->setNeedsCompositingUpdate();
193 } 199 }
194 200
195 void RemoteFrame::advanceFocus(WebFocusType type, LocalFrame* source) 201 void RemoteFrame::advanceFocus(WebFocusType type, LocalFrame* source)
196 { 202 {
197 remoteFrameClient()->advanceFocus(type, source); 203 remoteFrameClient()->advanceFocus(type, source);
198 } 204 }
199 205
200 } // namespace blink 206 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/RemoteFrame.h ('k') | third_party/WebKit/Source/core/frame/RemoteFrameClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698