Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1414463005: mojo: Add InThreadApplicationLoader. (Closed)

Created:
5 years, 2 months ago by xhwang
Modified:
4 years ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, piman+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mojo: Add InThreadApplicationLoader. NOT FOR REVIEW BUG=521754 TEST=Can create MojoMediaApplication on the GPU main thread.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -25 lines) Patch
M content/gpu/gpu_process_control_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/shell/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A + mojo/shell/in_thread_application_loader.h View 2 chunks +18 lines, -23 lines 0 comments Download
A mojo/shell/in_thread_application_loader.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
xhwang
Not for review, may not be needed, and definitely needs polish. Just FYI so you ...
5 years, 2 months ago (2015-10-20 23:19:10 UTC) #3
sandersd (OOO until July 31)
On 2015/10/20 23:19:10, xhwang (OOO Apr4 - Apr8) wrote: > Not for review, may not ...
4 years, 8 months ago (2016-04-05 17:55:37 UTC) #4
xhwang
4 years, 8 months ago (2016-04-05 23:58:14 UTC) #5 
On 2016/04/05 17:55:37, sandersd wrote:
> On 2015/10/20 23:19:10, xhwang (OOO Apr4 - Apr8) wrote:
> > Not for review, may not be needed, and definitely needs polish. Just FYI so
> you
> > know what I tried.
> > 
> > This is "working" for me in terms of successfully creating the
> > MojoMediaApplication on the GPU main thread :)
> 
> FYI I may end up using this for VDAv2. (It's either this, or pasing the main
> thread task runner to MojoMediaApplication. Not sure which is best yet.)

This is very old. You'll probably need CurrentThreadLoader or something like
https://chromiumcodereview.appspot.com/1856313002/

Powered by Google App Engine
This is Rietveld 408576698