chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java - Issue 1414453016: Data use UI fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

Issue 1414453016: Data use UI fixes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@plateIntentSource

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/datausage/DataUseTabUIManager.java ('k') | chrome/android/java/strings/android_chrome_strings.grd » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

index adacddf0b3761b3ea7672ce887ddc40f3bf5d538..9a02be475d08650ad1ccfa01c6929d63ce3ee0f5 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/snackbar/DataUseSnackbarController.java

@@ -34,14 +34,16 @@ public class DataUseSnackbarController implements SnackbarManager.SnackbarContro

public void showDataUseTrackingStartedBar() {

mSnackbarManager.showSnackbar(Snackbar.make(

mContext.getString(R.string.data_use_tracking_started_snackbar_message), this)

- .setAction(mContext.getString(R.string.data_use_tracking_started_snackbar_action),

+ .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),

null));

// TODO(megjablon): Add metrics.

}

public void showDataUseTrackingEndedBar() {

mSnackbarManager.showSnackbar(Snackbar.make(

- mContext.getString(R.string.data_use_tracking_ended_title), this));

+ mContext.getString(R.string.data_use_tracking_ended_title), this)

+ .setAction(mContext.getString(R.string.data_use_tracking_snackbar_action),

+ null));

// TODO(megjablon): Add metrics.

}