Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h

Issue 1414413002: SVG Web Animations: Add SVGInterpolationType pipeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@_svgAttributeReference
Patch Set: Move assert to not wrong location Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h
diff --git a/third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h b/third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h
similarity index 56%
copy from third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
copy to third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h
index c6298cdfa4ea97a303d69845a8e0527d23a9c7ac..959d812deeb34975915a1f051c80624944d572f6 100644
--- a/third_party/WebKit/Source/core/animation/CSSValueInterpolationType.h
+++ b/third_party/WebKit/Source/core/animation/SVGValueInterpolationType.h
@@ -2,27 +2,33 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CSSValueInterpolationType_h
-#define CSSValueInterpolationType_h
+#ifndef SVGValueInterpolationType_h
+#define SVGValueInterpolationType_h
-#include "core/animation/CSSInterpolationType.h"
+#include "core/animation/SVGInterpolationType.h"
namespace blink {
// Never supports pairwise conversion while always supporting single conversion.
-// A catch all for default for CSSValues.
-class CSSValueInterpolationType : public CSSInterpolationType {
+// A catch all default for SVGValues.
+class SVGValueInterpolationType : public SVGInterpolationType {
public:
- CSSValueInterpolationType(CSSPropertyID property)
- : CSSInterpolationType(property)
+ SVGValueInterpolationType(const QualifiedName& attribute)
+ : SVGInterpolationType(attribute)
{ }
+private:
PassOwnPtr<PairwisePrimitiveInterpolation> maybeConvertPairwise(const PropertySpecificKeyframe& startKeyframe, const PropertySpecificKeyframe& endKeyframe, const InterpolationEnvironment&, const UnderlyingValue&, ConversionCheckers&) const final
{
return nullptr;
}
- PassOwnPtr<InterpolationValue> maybeConvertSingle(const PropertySpecificKeyframe&, const InterpolationEnvironment&, const UnderlyingValue&, ConversionCheckers&) const final;
+ PassOwnPtr<InterpolationValue> maybeConvertNeutral() const final
+ {
+ return nullptr;
+ }
+
+ PassOwnPtr<InterpolationValue> maybeConvertSVGValue(const SVGPropertyBase&) const final;
PassOwnPtr<InterpolationValue> maybeConvertUnderlyingValue(const InterpolationEnvironment&) const final
{
@@ -34,9 +40,9 @@ public:
underlyingValue.set(&value);
}
- void apply(const InterpolableValue&, const NonInterpolableValue*, InterpolationEnvironment&) const final;
+ RefPtrWillBeRawPtr<SVGPropertyBase> appliedSVGValue(const InterpolableValue&, const NonInterpolableValue*) const final;
};
} // namespace blink
-#endif // CSSValueInterpolationType_h
+#endif // SVGValueInterpolationType_h

Powered by Google App Engine
This is Rietveld 408576698