Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: net/http/http_auth_handler_ntlm_win.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to cbentzel@'s comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_auth_handler_ntlm.cc ('k') | net/http/http_auth_preferences.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // See "SSPI Sample Application" at 5 // See "SSPI Sample Application" at
6 // http://msdn.microsoft.com/en-us/library/aa918273.aspx 6 // http://msdn.microsoft.com/en-us/library/aa918273.aspx
7 // and "NTLM Security Support Provider" at 7 // and "NTLM Security Support Provider" at
8 // http://msdn.microsoft.com/en-us/library/aa923611.aspx. 8 // http://msdn.microsoft.com/en-us/library/aa923611.aspx.
9 9
10 #include "net/http/http_auth_handler_ntlm.h" 10 #include "net/http/http_auth_handler_ntlm.h"
11 11
12 #include "base/strings/string_util.h" 12 #include "base/strings/string_util.h"
13 #include "net/base/net_errors.h" 13 #include "net/base/net_errors.h"
14 #include "net/base/net_util.h" 14 #include "net/base/net_util.h"
15 #include "net/http/http_auth_preferences.h"
15 #include "net/http/http_auth_sspi_win.h" 16 #include "net/http/http_auth_sspi_win.h"
16 #include "net/http/url_security_manager.h"
17 17
18 #pragma comment(lib, "secur32.lib") 18 #pragma comment(lib, "secur32.lib")
19 19
20 namespace net { 20 namespace net {
21 21
22 HttpAuthHandlerNTLM::HttpAuthHandlerNTLM( 22 HttpAuthHandlerNTLM::HttpAuthHandlerNTLM(
23 SSPILibrary* sspi_library, ULONG max_token_length, 23 SSPILibrary* sspi_library,
24 URLSecurityManager* url_security_manager) 24 ULONG max_token_length,
25 const HttpAuthPreferences* http_auth_preferences)
25 : auth_sspi_(sspi_library, "NTLM", NTLMSP_NAME, max_token_length), 26 : auth_sspi_(sspi_library, "NTLM", NTLMSP_NAME, max_token_length),
26 url_security_manager_(url_security_manager) { 27 http_auth_preferences_(http_auth_preferences) {}
27 }
28 28
29 HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() { 29 HttpAuthHandlerNTLM::~HttpAuthHandlerNTLM() {
30 } 30 }
31 31
32 // Require identity on first pass instead of second. 32 // Require identity on first pass instead of second.
33 bool HttpAuthHandlerNTLM::NeedsIdentity() { 33 bool HttpAuthHandlerNTLM::NeedsIdentity() {
34 return auth_sspi_.NeedsIdentity(); 34 return auth_sspi_.NeedsIdentity();
35 } 35 }
36 36
37 bool HttpAuthHandlerNTLM::AllowsDefaultCredentials() { 37 bool HttpAuthHandlerNTLM::AllowsDefaultCredentials() {
38 if (target_ == HttpAuth::AUTH_PROXY) 38 if (target_ == HttpAuth::AUTH_PROXY)
39 return true; 39 return true;
40 if (!url_security_manager_) 40 if (!http_auth_preferences_)
41 return false; 41 return false;
42 return url_security_manager_->CanUseDefaultCredentials(origin_); 42 return http_auth_preferences_->CanUseDefaultCredentials(origin_);
43 } 43 }
44 44
45 HttpAuthHandlerNTLM::Factory::Factory() 45 HttpAuthHandlerNTLM::Factory::Factory()
46 : max_token_length_(0), 46 : max_token_length_(0),
47 is_unsupported_(false) { 47 is_unsupported_(false) {
48 } 48 }
49 49
50 HttpAuthHandlerNTLM::Factory::~Factory() { 50 HttpAuthHandlerNTLM::Factory::~Factory() {
51 } 51 }
52 52
(...skipping 10 matching lines...) Expand all
63 if (max_token_length_ == 0) { 63 if (max_token_length_ == 0) {
64 int rv = DetermineMaxTokenLength(sspi_library_.get(), NTLMSP_NAME, 64 int rv = DetermineMaxTokenLength(sspi_library_.get(), NTLMSP_NAME,
65 &max_token_length_); 65 &max_token_length_);
66 if (rv == ERR_UNSUPPORTED_AUTH_SCHEME) 66 if (rv == ERR_UNSUPPORTED_AUTH_SCHEME)
67 is_unsupported_ = true; 67 is_unsupported_ = true;
68 if (rv != OK) 68 if (rv != OK)
69 return rv; 69 return rv;
70 } 70 }
71 // TODO(cbentzel): Move towards model of parsing in the factory 71 // TODO(cbentzel): Move towards model of parsing in the factory
72 // method and only constructing when valid. 72 // method and only constructing when valid.
73 scoped_ptr<HttpAuthHandler> tmp_handler( 73 scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerNTLM(
74 new HttpAuthHandlerNTLM(sspi_library_.get(), max_token_length_, 74 sspi_library_.get(), max_token_length_, http_auth_preferences()));
75 url_security_manager()));
76 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log)) 75 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log))
77 return ERR_INVALID_RESPONSE; 76 return ERR_INVALID_RESPONSE;
78 handler->swap(tmp_handler); 77 handler->swap(tmp_handler);
79 return OK; 78 return OK;
80 } 79 }
81 80
82 } // namespace net 81 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_auth_handler_ntlm.cc ('k') | net/http/http_auth_preferences.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698