Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Side by Side Diff: net/http/http_auth_handler_basic.cc

Issue 1414313002: Allow dynamic updating of authentication policies (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Respond to cbentzel@'s comments. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/http/http_auth.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/http/http_auth_handler_basic.h" 5 #include "net/http/http_auth_handler_basic.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/strings/string_util.h" 10 #include "base/strings/string_util.h"
11 #include "base/strings/utf_string_conversions.h" 11 #include "base/strings/utf_string_conversions.h"
12 #include "net/base/net_errors.h" 12 #include "net/base/net_errors.h"
13 #include "net/base/net_string_util.h" 13 #include "net/base/net_string_util.h"
14 #include "net/http/http_auth.h" 14 #include "net/http/http_auth.h"
15 #include "net/http/http_auth_challenge_tokenizer.h" 15 #include "net/http/http_auth_challenge_tokenizer.h"
16 #include "net/http/http_auth_scheme.h"
16 17
17 namespace net { 18 namespace net {
18 19
19 namespace { 20 namespace {
20 21
21 // Parses a realm from an auth challenge, and converts to UTF8-encoding. 22 // Parses a realm from an auth challenge, and converts to UTF8-encoding.
22 // Returns whether the realm is invalid or the parameters are invalid. 23 // Returns whether the realm is invalid or the parameters are invalid.
23 // 24 //
24 // Note that if a realm was not specified, we will default it to ""; 25 // Note that if a realm was not specified, we will default it to "";
25 // so specifying 'Basic realm=""' is equivalent to 'Basic'. 26 // so specifying 'Basic realm=""' is equivalent to 'Basic'.
(...skipping 29 matching lines...) Expand all
55 bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) { 56 bool HttpAuthHandlerBasic::Init(HttpAuthChallengeTokenizer* challenge) {
56 auth_scheme_ = HttpAuth::AUTH_SCHEME_BASIC; 57 auth_scheme_ = HttpAuth::AUTH_SCHEME_BASIC;
57 score_ = 1; 58 score_ = 1;
58 properties_ = 0; 59 properties_ = 0;
59 return ParseChallenge(challenge); 60 return ParseChallenge(challenge);
60 } 61 }
61 62
62 bool HttpAuthHandlerBasic::ParseChallenge( 63 bool HttpAuthHandlerBasic::ParseChallenge(
63 HttpAuthChallengeTokenizer* challenge) { 64 HttpAuthChallengeTokenizer* challenge) {
64 // Verify the challenge's auth-scheme. 65 // Verify the challenge's auth-scheme.
65 if (!base::LowerCaseEqualsASCII(challenge->scheme(), "basic")) 66 if (!base::LowerCaseEqualsASCII(challenge->scheme(), kBasicAuthScheme))
66 return false; 67 return false;
67 68
68 std::string realm; 69 std::string realm;
69 if (!ParseRealm(*challenge, &realm)) 70 if (!ParseRealm(*challenge, &realm))
70 return false; 71 return false;
71 72
72 realm_ = realm; 73 realm_ = realm;
73 return true; 74 return true;
74 } 75 }
75 76
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 // TODO(cbentzel): Move towards model of parsing in the factory 117 // TODO(cbentzel): Move towards model of parsing in the factory
117 // method and only constructing when valid. 118 // method and only constructing when valid.
118 scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerBasic()); 119 scoped_ptr<HttpAuthHandler> tmp_handler(new HttpAuthHandlerBasic());
119 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log)) 120 if (!tmp_handler->InitFromChallenge(challenge, target, origin, net_log))
120 return ERR_INVALID_RESPONSE; 121 return ERR_INVALID_RESPONSE;
121 handler->swap(tmp_handler); 122 handler->swap(tmp_handler);
122 return OK; 123 return OK;
123 } 124 }
124 125
125 } // namespace net 126 } // namespace net
OLDNEW
« no previous file with comments | « net/http/http_auth.cc ('k') | net/http/http_auth_handler_digest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698