src/ia32/ic-ia32.cc - Issue 14142005: Implement Polymorphic Store ICs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/ic-ia32.cc

Issue 14142005: Implement Polymorphic Store ICs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ia32/ic-ia32.cc

diff --git a/src/ia32/ic-ia32.cc b/src/ia32/ic-ia32.cc

index eb6ccd90e16151e756220fa155b5a417ca0fbfef..1df3faaad9a257f4ae7c9f25a9adc79c60cbb80f 100644

--- a/src/ia32/ic-ia32.cc

+++ b/src/ia32/ic-ia32.cc

@@ -1421,8 +1421,9 @@ void StoreIC::GenerateMegamorphic(MacroAssembler* masm,

// -- esp[0] : return address

// -----------------------------------

- Code::Flags flags =

- Code::ComputeFlags(Code::STORE_IC, MONOMORPHIC, strict_mode);

+ Code::Flags flags = Code::ComputeFlags(

+ Code::STUB, MONOMORPHIC, strict_mode,

+ Code::NORMAL, Code::STORE_IC);

Isolate::Current()->stub_cache()->GenerateProbe(masm, flags, edx, ecx, ebx,

no_reg);