Issue 14142005: Implement Polymorphic Store ICs

Issue 14142005: Implement Polymorphic Store ICs (Closed)

Created:
7 years, 8 months ago by Toon Verwaest

Modified:
7 years, 5 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

- Makes a common superclass for Load and Store stub compiler. - Splits all non-normal Store ICs into handler and IC. - Ensures monomorphic store ICs go polymorphic. - Feeds polymorphic type feedback into count operation. R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15566

Patch Set 1 : #

Patch Set 2 : Addressed comments #

Total comments: 6

Patch Set 3 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+753 lines, -666 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	1 2	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/arm/ic-arm.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	1 2	13 chunks	+72 lines, -113 lines	0 comments	Download
M	src/ast.cc	View	1 2	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 2	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/ia32/ic-ia32.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/ia32/stub-cache-ia32.cc	View	1 2	15 chunks	+71 lines, -137 lines	0 comments	Download
M	src/ic.h	View		5 chunks	+41 lines, -5 lines	0 comments	Download
M	src/ic.cc	View		7 chunks	+66 lines, -18 lines	0 comments	Download
M	src/stub-cache.h	View	1	12 chunks	+190 lines, -128 lines	0 comments	Download
M	src/stub-cache.cc	View	1	30 chunks	+190 lines, -109 lines	0 comments	Download
M	src/type-info.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/type-info.cc	View	1 2	3 chunks	+17 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 2	3 chunks	+6 lines, -3 lines	0 comments	Download
M	src/x64/ic-x64.cc	View	1 2	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/x64/stub-cache-x64.cc	View	1 2	15 chunks	+72 lines, -135 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

PTAL Depends on https://codereview.chromium.org/13923003/

7 years, 8 months ago (2013-04-11 13:42:00 UTC) #1

ulan

LGTM https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc#newcode448 src/arm/stub-cache-arm.cc:448: masm, Nit: arguments fit in one or two ...

7 years, 5 months ago (2013-07-09 08:08:38 UTC) #3

Toon Verwaest

Addressed comments (sorry, rebased in the new CL before uploading...) https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://chromiumcodereview.appspot.com/14142005/diff/41001/src/arm/stub-cache-arm.cc#newcode448 ...

7 years, 5 months ago (2013-07-09 08:22:26 UTC) #4

Toon Verwaest

7 years, 5 months ago (2013-07-09 08:22:52 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r15566 (presubmit successful).

Expand Messages | Collapse Messages