Allow metadata fields to be PropertyConverters for symmetry.

service/datastore/pls.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package datastore
 
 import (
         "reflect"
 )
 
@@ skipping 107 matching lines @@
 //     if err != nil {
 //       return nil, err
 //     }
 //     props["foo"] = []Property{MkProperty(s.foo)}
 //     return props, nil
 //   }
 //
 //   func (s *Special) Problem() error {
 //     return GetPLS(s).Problem()
 //   }
+//
+// Additionally, any field ptr-to-type may implement the PropertyConverter
+// interface to allow a single field to, for example, implement some alternate
+// encoding (json, gzip), or even just serialize to/from a simple string field.
+// This applies to normal fields, as well as metadata fields. It can be useful
+// for storing struct '$id's which have multi-field meanings. For example, the
+// Person struct below could be initialized in go as `&Person{Name{"Jane",
+// "Doe"}}`, retaining Jane's name as manipulable go fields. However, in the

[dnj, 2015/11/03 03:11:25]

nit: capitalize Go.

[iannucci, 2015/11/03 20:29:33]

done

+// datastore, it would have a key of `/Person,"Jane|Doe"`, and loading the
+// struct from the datastore as part of a Query, for example, would correct

[dnj, 2015/11/03 03:11:25]

nit: correctly*

[iannucci, 2015/11/03 20:29:33]

done

+// populate Person.Name.First and Person.Name.Last.
+//
+//   type Name struct {
+//     First string
+//     Last string
+//   }
+//
+//   func (n *Name) ToProperty() (Property, error) {
+//     return fmt.Sprintf("%s|%s", n.First, n.Last)
+//   }
+//
+//   func (n *Name) FromProperty(p Property) error {
+//     // check p to be a PTString
+//     // split on "|"
+//     // assign to n.First, n.Last
+//   }
+//
+//   type Person struct {
+//     Name `gae:"$id"`
+//   }
 func GetPLS(obj interface{}) interface {
         PropertyLoadSaver
         MetaGetterSetter
 } {
         v := reflect.ValueOf(obj)
         if v.Kind() != reflect.Ptr || v.Elem().Kind() != reflect.Struct {
                 return &structPLS{c: &structCodec{problem: ErrInvalidEntityType}}
         }
         if v.IsNil() {
                 return &structPLS{c: &structCodec{problem: ErrInvalidEntityType}}
@@ skipping 15 matching lines @@
         c, ok := structCodecs[structType]
         structCodecsMutex.RUnlock()
         if ok {
                 return c
         }
 
         structCodecsMutex.Lock()
         defer structCodecsMutex.Unlock()
         return getStructCodecLocked(structType)
 }