Clean up VMState a little bit.

Clean up VMState a little bit.

R=svenpanne@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=14421

[Sven Panne, 2013-04-24 14:03:41]

https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h
File src/vm-state-inl.h (right):

https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h#newcode64
src/vm-state-inl.h:64: if (FLAG_log_timer_events && previous_tag_ != EXTERNAL &&
Tag == EXTERNAL) {
Do we really don't want to call set_current_vm_state for EXTERNAL? If yes,
template specialization (for EXTERNAL) makes things a bit clearer here.

[Yang, 2013-04-24 14:11:22]

On 2013/04/24 14:03:41, Sven Panne wrote:
> https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h
> File src/vm-state-inl.h (right):
> 
> https://codereview.chromium.org/14139033/diff/1/src/vm-state-inl.h#newcode64
> src/vm-state-inl.h:64: if (FLAG_log_timer_events && previous_tag_ != EXTERNAL
&&
> Tag == EXTERNAL) {
> Do we really don't want to call set_current_vm_state for EXTERNAL? If yes,
> template specialization (for EXTERNAL) makes things a bit clearer here.

Thanks for catching this mistake! Fixed in the new patch set.

[Sven Panne, 2013-04-24 14:40:29]

lgtm

[Yang, 2013-04-24 14:44:25]

Committed patchset #2 manually as r14421 (presubmit successful).