Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: webkit/base/data_element.h

Issue 14139026: New blobstoragecontext for use in the main browser process, not plugged in yet. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_tests.gypi ('k') | webkit/base/data_element.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/base/data_element.h
===================================================================
--- webkit/base/data_element.h (revision 197440)
+++ webkit/base/data_element.h (working copy)
@@ -5,6 +5,7 @@
#ifndef WEBKIT_BASE_DATA_ELEMENT_H_
#define WEBKIT_BASE_DATA_ELEMENT_H_
+#include <string>
#include <vector>
#include "base/basictypes.h"
@@ -34,13 +35,26 @@
Type type() const { return type_; }
const char* bytes() const { return bytes_ ? bytes_ : &buf_[0]; }
const base::FilePath& path() const { return path_; }
- const GURL& url() const { return url_; }
+ const GURL& filesystem_url() const { return filesystem_url_; }
+
+ // TODO(michaeln): crbug/174200, fully switch to using string uuids.
+ // Note: Identifying blobs by url is being deprecated, but while
+ // transitioning, there's a little of both going on in the project.
+ const std::string& blob_uuid() const { return blob_uuid_; }
+ const GURL& blob_url() const { return blob_url_; }
uint64 offset() const { return offset_; }
uint64 length() const { return length_; }
const base::Time& expected_modification_time() const {
return expected_modification_time_;
}
+ // TODO(michaeln): fixup callers to use filesytem_url() and blob_uuid().
+ const GURL& url() const {
+ if (type_ == TYPE_FILE_FILESYSTEM)
+ return filesystem_url_;
+ return blob_url_;
+ }
+
// Sets TYPE_BYTES data. This copies the given data into the element.
void SetToBytes(const char* bytes, int bytes_len) {
type_ = TYPE_BYTES;
@@ -65,6 +79,9 @@
void SetToBlobUrl(const GURL& blob_url) {
SetToBlobUrlRange(blob_url, 0, kuint64max);
}
+ void SetToBlob(const std::string& uuid) {
+ SetToBlobRange(uuid, 0, kuint64max);
+ }
// Sets TYPE_FILE data with range.
void SetToFilePathRange(const base::FilePath& path,
@@ -74,6 +91,8 @@
// Sets TYPE_BLOB data with range.
void SetToBlobUrlRange(const GURL& blob_url,
uint64 offset, uint64 length);
+ void SetToBlobRange(const std::string& blob_uuid,
+ uint64 offset, uint64 length);
// Sets TYPE_FILE_FILESYSTEM with range.
void SetToFileSystemUrlRange(const GURL& filesystem_url,
@@ -85,7 +104,9 @@
std::vector<char> buf_; // For TYPE_BYTES.
const char* bytes_; // For TYPE_BYTES.
base::FilePath path_; // For TYPE_FILE.
- GURL url_; // For TYPE_BLOB or TYPE_FILE_FILESYSTEM.
+ GURL filesystem_url_; // For TYPE_FILE_FILESYSTEM.
+ GURL blob_url_;
+ std::string blob_uuid_;
uint64 offset_;
uint64 length_;
base::Time expected_modification_time_;
@@ -104,8 +125,10 @@
return a.path() == b.path() &&
a.expected_modification_time() == b.expected_modification_time();
case DataElement::TYPE_BLOB:
+ return a.blob_uuid().empty() ? (a.blob_url() == b.blob_url())
+ : (a.blob_uuid() == b.blob_uuid());
case DataElement::TYPE_FILE_FILESYSTEM:
- return a.url() == b.url();
+ return a.filesystem_url() == b.filesystem_url();
case DataElement::TYPE_UNKNOWN:
NOTREACHED();
return false;
« no previous file with comments | « content/content_tests.gypi ('k') | webkit/base/data_element.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698