Create profile .ico file on profile creation

chrome/browser/profiles/profile_shortcut_manager_win.h

Index: chrome/browser/profiles/profile_shortcut_manager_win.h
diff --git a/chrome/browser/profiles/profile_shortcut_manager_win.h b/chrome/browser/profiles/profile_shortcut_manager_win.h
index 631a71303e6cbef73a4e7c411211ee0010c073ab..28a8e95086a5ddc4f2a26eee99adf60948d178c9 100644
--- a/chrome/browser/profiles/profile_shortcut_manager_win.h
+++ b/chrome/browser/profiles/profile_shortcut_manager_win.h
@@ -16,6 +16,9 @@ namespace internal {
 // Name of the badged icon file generated for a given profile.
 extern const char kProfileIconFileName[];
 
+// Returns the full path to the profile icon file.
+base::FilePath GetProfileIconPath(const base::FilePath& profile_path);
+
 // Returns the default shortcut filename for the given profile name,
 // given |distribution|. Returns a filename appropriate for a
 // single-user installation if |profile_name| is empty.
@@ -31,10 +34,13 @@ string16 CreateProfileShortcutFlags(const base::FilePath& profile_path);
 class ProfileShortcutManagerWin : public ProfileShortcutManager,
                                   public ProfileInfoCacheObserver {
  public:
-  // Specifies whether a new shortcut should be created if none exist.
+  // Specifies whether the only existing shortcuts should be updated, a new

[gab, 2013/05/07 12:38:39]

s/the only/only the

[calamity, 2013/05/08 08:15:42]

Done.

+  // shortcut should be created if none exist, or only the icon for this profile
+  // should be updated.

[gab, 2013/05/07 12:38:39]

s/updated./created in the profile directory.

[calamity, 2013/05/08 08:15:42]

Done.

   enum CreateOrUpdateMode {
     UPDATE_EXISTING_ONLY,
     CREATE_WHEN_NONE_FOUND,
+    CREATE_ICON_ONLY,
   };
   // Specifies whether non-profile shortcuts should be updated.
   enum NonProfileShortcutAction {
@@ -46,6 +52,8 @@ class ProfileShortcutManagerWin : public ProfileShortcutManager,
   virtual ~ProfileShortcutManagerWin();
 
   // ProfileShortcutManager implementation:
+  virtual void CreateProfileIcon(
+      const base::FilePath& profile_path) OVERRIDE;

[Alexei Svitkine (slow), 2013/05/03 17:20:47]

Please add a unit test for this. (i.e. create a profile, ensure that an icon got
created, then delete it and call this function and ensure it got created again.)

[calamity, 2013/05/08 08:15:42]

Done.

   virtual void CreateProfileShortcut(
       const base::FilePath& profile_path) OVERRIDE;
   virtual void RemoveProfileShortcuts(