Create profile .ico file on profile creation

chrome/browser/profiles/profile_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/command_line.h"
 #include "base/compiler_specific.h"
@@ skipping 731 matching lines @@
   } else {
     last_session_exit_type_ =
         SessionTypePrefValueToExitType(exit_type_pref_value);
   }
   // Mark the session as open.
   prefs_->SetString(prefs::kSessionExitType, kPrefExitTypeCrashed);
   // Force this to true in case we fallback and use it.
   // TODO(sky): remove this in a couple of releases (m28ish).
   prefs_->SetBoolean(prefs::kSessionExitedCleanly, true);
 
+#if defined(OS_WIN)
+  // Ensure the profile's icon file has been created.
+  ProfileShortcutManager* profile_shortcut_manager =

[Alexei Svitkine (slow), 2013/05/09 16:45:47]

I still think we should only do this if the pref isn't set.

We don't want to be posting an additional task to the FILE thread on every
startup. Sure, it won't block UI, but the more things that get posted during
startup, the slower Chrome runs initially until it catches up with the list of
things that have been posted. This is bad.

Consider that once users have ran this once, the expected case will be that for
99.9% of users, the icon already exists and is just fine, so you're now bogging
down the FILE thread more for those users needlessly. Having the pref eliminates
that except for when the icon hasn't been created.

And no, I don't think the hashing code solves the problem. You're still posting
a task to the FILE thread that gets run on startup, delaying other tasks. That
task still ends up generating the SkBitmaps, up to 256x256 in size, which is
still a lot of processing. Plus, with the hashing it now has to read a file
(storing the hash) to figure out if the hash matches or not.

All of this is non-trivial and without the pref, you'd be doing it all
redundantly for 99.9% of cases, once the icon has been made.

So I still think you should use the pref here. That way, you'll only be posting
the task when it's needed.

[calamity, 2013/05/24 08:58:48]

Done.

+      g_browser_process->profile_manager()->profile_shortcut_manager();
+  if (profile_shortcut_manager)
+    profile_shortcut_manager->CreateProfileIcon(GetPath());
+#endif
+
   ProfileDependencyManager::GetInstance()->CreateProfileServices(this, false);
 
   DCHECK(!net_pref_observer_.get());
   net_pref_observer_.reset(new NetPrefObserver(
       prefs_.get(),
       prerender::PrerenderManagerFactory::GetForProfile(this),
       predictor_));
 
   ChromeVersionService::OnProfileLoaded(prefs_.get(), IsNewProfile());
   DoFinalInit();
@@ skipping 402 matching lines @@
                                      base::FilePath* cache_path,
                                      int* max_size) {
   DCHECK(cache_path);
   DCHECK(max_size);
   base::FilePath path(prefs_->GetFilePath(prefs::kDiskCacheDir));
   if (!path.empty())
     *cache_path = path;
   *max_size = is_media_context ? prefs_->GetInteger(prefs::kMediaCacheSize) :
                                  prefs_->GetInteger(prefs::kDiskCacheSize);
 }