Create profile .ico file on profile creation

chrome/browser/chrome_browser_main.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_browser_main.h"
 
 #if defined(TOOLKIT_GTK)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 339 matching lines @@
 #if defined(OS_CHROMEOS)
   // TODO(ivankr): http://crbug.com/83792
   profile = g_browser_process->profile_manager()->GetDefaultProfile(
       user_data_dir);
 #else
   base::FilePath profile_path =
       GetStartupProfilePath(user_data_dir, parsed_command_line);
   profile = g_browser_process->profile_manager()->GetProfile(
       profile_path);
 #endif
-  if (profile)
+  if (profile) {
+#if defined(OS_WIN)
+    // Ensure the icon file for the profile has been created.

[Alexei Svitkine (slow), 2013/05/09 16:45:47]

Does ProfileImpl::OnPrefsLoaded() not get called in this case?

Seems strange to me if that would be the case. If it does get called, then you
don't need this here, right?

[calamity, 2013/05/24 08:58:48]

Yep, sorry. I got confused. ProfileManager::OnProfileCreated isn't called for
the startup profile but ProfileImpl::OnPrefsLoaded is.

+    ProfileShortcutManager* profile_shortcut_manager =
+        g_browser_process->profile_manager()->profile_shortcut_manager();
+    if (profile_shortcut_manager)
+      profile_shortcut_manager->CreateProfileIcon(profile->GetPath());
+#endif
     return profile;
+  }
 
 #if !defined(OS_WIN)
   // TODO(port): fix this.  See comments near the definition of
   // user_data_dir.  It is better to CHECK-fail here than it is to
   // silently exit because of missing code in the above test.
   CHECK(profile) << "Cannot get default profile.";
 #endif
 
   return NULL;
 }
@@ skipping 1375 matching lines @@
     if (base::win::GetVersion() <= base::win::VERSION_XP)
       uma_name += "_XP";
 
     uma_name += "_PreRead_";
     uma_name += pre_read_percentage;
     AddPreReadHistogramTime(uma_name.c_str(), time);
   }
 #endif
 #endif
 }