Remove base/mac/mach_ipc_mac.{h,mm}.

Remove base/mach_ipc_mac.{h,mm}.

The only bit that was still being used was GetNumberOfMachPorts(). Move the
impl of that into its one caller.

BUG=none

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194022

[Mark Mentovai, 2013-04-11 17:02:56]

LGTM otherwise

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:499: kern_return_t kr =
mach_port_names(mach_task_self(), &names, &names_count,
local for mach_task_self() (yeah, even though…)

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:502: *port_count = -1;
-1 for failure on Mac but 0 for “not implemented” on other platforms?

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:510:
vm_deallocate(mach_task_self(),
For 64-bit compatibility, use mach_vm_deallocate instead of vm_deallocate, and
use mach_vm_address_t instead of vm_address_t.

[Robert Sesek, 2013-04-11 17:10:32]

+brettw for OWNERS stamp

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
File chrome/browser/automation/testing_automation_provider.cc (right):

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:499: kern_return_t kr =
mach_port_names(mach_task_self(), &names, &names_count,
On 2013/04/11 17:02:56, Mark Mentovai wrote:
> local for mach_task_self() (yeah, even though…)

Done.

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:502: *port_count = -1;
On 2013/04/11 17:02:56, Mark Mentovai wrote:
> -1 for failure on Mac but 0 for “not implemented” on other platforms?

Done.

https://codereview.chromium.org/14137013/diff/1/chrome/browser/automation/tes...
chrome/browser/automation/testing_automation_provider.cc:510:
vm_deallocate(mach_task_self(),
On 2013/04/11 17:02:56, Mark Mentovai wrote:
> For 64-bit compatibility, use mach_vm_deallocate instead of vm_deallocate, and
> use mach_vm_address_t instead of vm_address_t.

Done.

[Mark Mentovai, 2013-04-11 17:50:14]

LGTM

[Avi (use Gerrit), 2013-04-12 18:52:45]

lgtm

drive-by owner stamp

[Paweł Hajdan Jr., 2013-04-12 18:54:31]

chrome/browser/automation OWNER LGTM

[commit-bot: I haz the power, 2013-04-12 18:55:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsesek@chromium.org/14137013/5001

[commit-bot: I haz the power, 2013-04-12 21:48:58]

Change committed as 194022