native_client_sdk/src/build_tools/sdk_tools/command/update.py - Issue 1413663005: Do not fail checksum check before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: native_client_sdk/src/build_tools/sdk_tools/command/update.py

Issue 1413663005: Do not fail checksum check before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adding myself to chromium/AUTHORS Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: native_client_sdk/src/build_tools/sdk_tools/command/update.py

diff --git a/native_client_sdk/src/build_tools/sdk_tools/command/update.py b/native_client_sdk/src/build_tools/sdk_tools/command/update.py

index e49765bb2de84f724bee00d717d5ac2eacd45f59..5ad5b825f2b72ea6563c088754a7de576e09e481 100644

--- a/native_client_sdk/src/build_tools/sdk_tools/command/update.py

+++ b/native_client_sdk/src/build_tools/sdk_tools/command/update.py

@@ -74,7 +74,7 @@ class RealUpdateDelegate(UpdateDelegate):

archive.size, filename))

return False

sha1_hash = hashlib.sha1()

- with open(filename) as f:

+ with open(filename, 'rb') as f:

sha1_hash.update(f.read())

if sha1_hash.hexdigest() != archive.GetChecksum():

logging.info('File hash does not match: %s.' % filename)

« no previous file with comments | « native_client_sdk/src/AUTHORS ('k') | no next file » | no next file with comments »