Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1413603004: Delay embed-element focus until after plugin creation. (Closed)

Created:
5 years, 2 months ago by wjmaclean
Modified:
5 years, 2 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Delay embed-element focus until after plugin creation. This cl fixes a subtle issue with BrowserPlugin plugin focus after a reload. BUG=544802 Committed: https://crrev.com/0e59812ad761edd22e983166aee703a84996158b Cr-Commit-Position: refs/heads/master@{#355189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/core/html/PluginDocument.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
wjmaclean
Apparently I was focusing the embed element before the plugin was actually loaded, and this ...
5 years, 2 months ago (2015-10-20 14:22:26 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413603004/1
5 years, 2 months ago (2015-10-20 14:23:04 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-20 15:50:29 UTC) #7
esprehn
I wonder if you can write a Sim* test for this... lgtm
5 years, 2 months ago (2015-10-20 21:13:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1413603004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1413603004/1
5 years, 2 months ago (2015-10-20 23:37:51 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 00:07:07 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 00:08:43 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0e59812ad761edd22e983166aee703a84996158b
Cr-Commit-Position: refs/heads/master@{#355189}

Powered by Google App Engine
This is Rietveld 408576698