Remove gclient_utils.RemoveDirectory().

Remove gclient_utils.RemoveDirectory().

The 'RemoveDirectory()' function in gclient_utils is deprecated and
rmtree() should be used instead for consistency.

This patch modifies all clients in depot_tools to use rmtree() instead
and removes the RemoveDirectory function.

+ The SVNWrapperTestCase.testRevertNoDotSvn() mocking
  expectation has been slightly changed. This was required
  because the test invokes code that used to call
  gclient_utils.RemoveDirectory() directly, while only
  gclient_utils.rmtree() was mocked.

BUG=NONE
R=maruel@chromium.org, ilevy@chromium.org
TEST=manually run gclient_utils_test / gclient_smoketest / scm_unittest / gclient_scm_test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=196133

[M-A Ruel, 2013-04-23 20:15:15]

Humm, it's exactly the reverse. RemoveDirectory is the deprecated name.

For open source code, we favor the lower_case name for functions instead of
CamelCase which never made sense for function and members, as stated in PEP-8.
We keep alignment at +2 because we are insane.

[digit, 2013-04-23 20:45:13]

Ah ah :-) Ok, I'll update the patch tomorrow. Thanks for the clarification.

[Isaac (away), 2013-04-23 21:01:14]

this lgtm but I'm not a depot_tools owner.

[digit1, 2013-04-24 08:56:09]

Patch Set 2 reinstantes rmtree() and gets rid of RemoveDirectory(), please take
a look.

[M-A Ruel, 2013-04-24 12:52:03]

lgtm, thanks

[commit-bot: I haz the power, 2013-04-24 12:58:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/digit@chromium.org/14134010/5001

[commit-bot: I haz the power, 2013-04-24 13:00:19]

Change committed as 196133