Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Unified Diff: chromeos/dbus/shill_service_client_stub.cc

Issue 14134007: NetworkPortalDetector/NetworkStateInformer: Switch over to use NetworkStateHandler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase again Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_service_client_stub.cc
diff --git a/chromeos/dbus/shill_service_client_stub.cc b/chromeos/dbus/shill_service_client_stub.cc
index 434c4ceadb00b9394cc7ace2f2f3b35bd64e51c9..7f03089bcde09dcdc748f7061a525f427ef99e8d 100644
--- a/chromeos/dbus/shill_service_client_stub.cc
+++ b/chromeos/dbus/shill_service_client_stub.cc
@@ -106,10 +106,13 @@ void ShillServiceClientStub::SetProperty(const dbus::ObjectPath& service_path,
return;
}
if (name == flimflam::kStateProperty) {
- // If we connect to a service, then we move it to the top of the list in
- // the manager client.
+ // If the service went into a connected state, then move it to the top of
+ // the list in the manager client.
+ // TODO(gauravsh): Generalize to sort services properly to allow for testing
+ // more complex scenarios.
std::string state;
- if (value.GetAsString(&state) && state == flimflam::kStateOnline) {
+ if (value.GetAsString(&state) && (state == flimflam::kStateOnline ||
+ state == flimflam::kStatePortal)) {
ShillManagerClient* manager_client =
DBusThreadManager::Get()->GetShillManagerClient();
manager_client->GetTestInterface()->MoveServiceToIndex(
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc ('k') | chromeos/network/network_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698