Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 14134005: Simple Cache: Re-enable entry counting in tests on start (Closed)

Created:
7 years, 8 months ago by pasko-google - do not use
Modified:
7 years, 8 months ago
Reviewers:
felipeg, gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Visibility:
Public.

Description

Simple Cache: Re-enable entry counting in tests on start GetEntryCount() was implemented recently with: http://crrev.com/14295013 Now addressing the forgotten TODO. BUG=230306 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/disk_cache/disk_cache_test_base.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pasko-google - do not use
7 years, 8 months ago (2013-04-18 17:45:48 UTC) #1
felipeg
LGTM can you also look for related TODOs in the entry_unittest
7 years, 8 months ago (2013-04-18 17:54:28 UTC) #2
pasko-google - do not use
On 2013/04/18 17:54:28, felipeg1 wrote: > LGTM > can you also look for related TODOs ...
7 years, 8 months ago (2013-04-18 18:06:12 UTC) #3
gavinp
lgtm
7 years, 8 months ago (2013-04-19 05:55:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pasko@google.com/14134005/1
7 years, 8 months ago (2013-04-19 08:39:51 UTC) #5
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 14:25:23 UTC) #6
Message was sent while issue was closed.
Change committed as 195179

Powered by Google App Engine
This is Rietveld 408576698