InstantExtendedManualTests should fail and not hang

InstantExtendedManualTests should fail and not hang

Converts hanging tests to failures. Also disables a couple more flakey
manual tests.

BUG=225517
TEST=InstantExtendedManualTests.*
R=jered@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194802

[Jered, 2013-04-16 22:35:57]

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
File chrome/browser/ui/search/instant_test_utils.cc (right):

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
chrome/browser/ui/search/instant_test_utils.cc:54: observed_mode_type_ =
model.mode().mode;
I'm worried that this might break some tests which previously skipped over
intermediate updates to an undesired state. Please try it out. But I think
that's fishy enough that we should disable such tests.

[dhollowa, 2013-04-16 22:50:51]

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
File chrome/browser/ui/search/instant_test_utils.cc (right):

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
chrome/browser/ui/search/instant_test_utils.cc:54: observed_mode_type_ =
model.mode().mode;
On 2013/04/16 22:35:57, Jered wrote:
> I'm worried that this might break some tests which previously skipped over
> intermediate updates to an undesired state. Please try it out. But I think
> that's fishy enough that we should disable such tests.

Yes, I verified.  No problems with this.

[Jered, 2013-04-16 22:53:37]

On 2013/04/16 22:50:51, dhollowa wrote:
>
https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
> File chrome/browser/ui/search/instant_test_utils.cc (right):
> 
>
https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
> chrome/browser/ui/search/instant_test_utils.cc:54: observed_mode_type_ =
> model.mode().mode;
> On 2013/04/16 22:35:57, Jered wrote:
> > I'm worried that this might break some tests which previously skipped over
> > intermediate updates to an undesired state. Please try it out. But I think
> > that's fishy enough that we should disable such tests.
> 
> Yes, I verified.  No problems with this.

lgtm

Just on mac? I'm cautiously optimistic. :-)

[dhollowa, 2013-04-16 22:54:56]

On 2013/04/16 22:53:37, Jered wrote:
> On 2013/04/16 22:50:51, dhollowa wrote:
> >
>
https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
> > File chrome/browser/ui/search/instant_test_utils.cc (right):
> > 
> >
>
https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
> > chrome/browser/ui/search/instant_test_utils.cc:54: observed_mode_type_ =
> > model.mode().mode;
> > On 2013/04/16 22:35:57, Jered wrote:
> > > I'm worried that this might break some tests which previously skipped over
> > > intermediate updates to an undesired state. Please try it out. But I think
> > > that's fishy enough that we should disable such tests.
> > 
> > Yes, I verified.  No problems with this.
> 
> lgtm
> 
> Just on mac? I'm cautiously optimistic. :-)

Yes, just on Mac.  But I'll run through the trybots before landing.

[James Cook, 2013-04-16 22:57:14]

Drive-by comment

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
File chrome/browser/ui/search/instant_test_utils.h (right):

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
chrome/browser/ui/search/instant_test_utils.h:36: ~InstantTestModelObserver();
drive-by comment: needs "virtual"

[dhollowa, 2013-04-16 23:01:43]

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
File chrome/browser/ui/search/instant_test_utils.h (right):

https://codereview.chromium.org/14130012/diff/3001/chrome/browser/ui/search/i...
chrome/browser/ui/search/instant_test_utils.h:36: ~InstantTestModelObserver();
On 2013/04/16 22:57:14, James Cook (Chromium) wrote:
> drive-by comment: needs "virtual"

Done.

[commit-bot: I haz the power, 2013-04-18 00:28:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dhollowa@chromium.org/14130012/11001

[commit-bot: I haz the power, 2013-04-18 06:19:31]

Change committed as 194802