Issue 14130006: Explicitly pass "--diff-cmd diff" to "svn diff", for users who have set some other diff tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14130006: Explicitly pass "--diff-cmd diff" to "svn diff", for users who have set some other diff tool. (Closed)

Created:
7 years, 8 months ago by Peter Kasting

Modified:
7 years, 8 months ago

Reviewers:
M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/tools/depot_tools/

Visibility:
Public.

Explicitly pass "--diff-cmd diff" to "svn diff", for users who have set some other diff tool.

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	scm.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

M-A Ruel

lgtm. I'd prefer for you to use the CQ once it's back up, which should ...

7 years, 8 months ago (2013-04-16 20:17:44 UTC) #2

Peter Kasting

On 2013/04/16 20:17:44, Marc-Antoine Ruel wrote: > lgtm. > > I'd prefer for you to ...

7 years, 8 months ago (2013-04-16 20:21:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkasting@chromium.org/14130006/1

7 years, 8 months ago (2013-04-18 00:28:39 UTC) #4

Message was sent while issue was closed.

Change committed as 194740