Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Unified Diff: content/browser/frame_host/render_widget_host_view_guest.cc

Issue 1412923009: Route touch-events for WebViewGuest directly to guest renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments (saving first this time). Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_widget_host_view_guest.cc
diff --git a/content/browser/frame_host/render_widget_host_view_guest.cc b/content/browser/frame_host/render_widget_host_view_guest.cc
index 8971b07fad35b9e8b6f6c4467791655b3e6c4115..a3d6ded4556bc348051daa8d900894309b3f7f58 100644
--- a/content/browser/frame_host/render_widget_host_view_guest.cc
+++ b/content/browser/frame_host/render_widget_host_view_guest.cc
@@ -14,6 +14,8 @@
#include "content/browser/compositor/surface_utils.h"
#include "content/browser/frame_host/render_widget_host_view_guest.h"
#include "content/browser/renderer_host/render_view_host_impl.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
+#include "content/browser/renderer_host/render_widget_host_input_event_router.h"
#include "content/common/browser_plugin/browser_plugin_messages.h"
#include "content/common/frame_messages.h"
#include "content/common/gpu/gpu_messages.h"
@@ -56,16 +58,9 @@ RenderWidgetHostViewGuest::RenderWidgetHostViewGuest(
// |guest| is NULL during test.
guest_(guest ? guest->AsWeakPtr() : base::WeakPtr<BrowserPluginGuest>()),
platform_view_(platform_view) {
-#if defined(USE_AURA)
- gesture_recognizer_.reset(ui::GestureRecognizer::Create());
- gesture_recognizer_->AddGestureEventHelper(this);
-#endif // defined(USE_AURA)
}
RenderWidgetHostViewGuest::~RenderWidgetHostViewGuest() {
-#if defined(USE_AURA)
- gesture_recognizer_->RemoveGestureEventHelper(this);
-#endif // defined(USE_AURA)
}
bool RenderWidgetHostViewGuest::OnMessageReceivedFromEmbedder(
@@ -133,29 +128,43 @@ bool RenderWidgetHostViewGuest::HasFocus() const {
#if defined(USE_AURA)
void RenderWidgetHostViewGuest::ProcessAckedTouchEvent(
const TouchEventWithLatencyInfo& touch, InputEventAckState ack_result) {
- // TODO(fsamuel): Currently we will only take this codepath if the guest has
- // requested touch events. A better solution is to always forward touchpresses
- // to the embedder process to target a BrowserPlugin, and then route all
- // subsequent touch points of that touchdown to the appropriate guest until
- // that touch point is released.
- ScopedVector<ui::TouchEvent> events;
- if (!MakeUITouchEventsFromWebTouchEvents(touch, &events, LOCAL_COORDINATES))
- return;
+ // TODO(tdresser): Since all ProcessAckedTouchEvent() uses is the event id,
+ // don't pass the full event object here. https://crbug.com/550581.
+ GetOwnerRenderWidgetHostView()->ProcessAckedTouchEvent(touch, ack_result);
+}
+#endif
- ui::EventResult result = (ack_result ==
- INPUT_EVENT_ACK_STATE_CONSUMED) ? ui::ER_HANDLED : ui::ER_UNHANDLED;
- for (ScopedVector<ui::TouchEvent>::iterator iter = events.begin(),
- end = events.end(); iter != end; ++iter) {
- if (!gesture_recognizer_->ProcessTouchEventPreDispatch(*iter, this))
- continue;
-
- scoped_ptr<ui::GestureRecognizer::Gestures> gestures;
- gestures.reset(gesture_recognizer_->AckTouchEvent(
- (*iter)->unique_event_id(), result, this));
- ProcessGestures(gestures.get());
+void RenderWidgetHostViewGuest::ProcessTouchEvent(
+ const blink::WebTouchEvent& event,
+ const ui::LatencyInfo& latency) {
+ if (event.type == blink::WebInputEvent::TouchStart) {
+ DCHECK(guest_->GetOwnerRenderWidgetHostView());
+ RenderWidgetHostImpl* embedder = static_cast<RenderWidgetHostImpl*>(
+ guest_->GetOwnerRenderWidgetHostView()->GetRenderWidgetHost());
+ if (!embedder->GetView()->HasFocus())
+ embedder->GetView()->Focus();
+ }
+
+ host_->ForwardTouchEventWithLatencyInfo(event, latency);
+}
+
+void RenderWidgetHostViewGuest::RegisterSurfaceNamespaceId() {
+ DCHECK(host_);
+ if (host_->delegate() && host_->delegate()->GetInputEventRouter()) {
+ RenderWidgetHostInputEventRouter* router =
+ host_->delegate()->GetInputEventRouter();
+ if (!router->is_registered(GetSurfaceIdNamespace()))
+ router->AddSurfaceIdNamespaceOwner(GetSurfaceIdNamespace(), this);
+ }
+}
+
+void RenderWidgetHostViewGuest::UnregisterSurfaceNamespaceId() {
+ DCHECK(host_);
+ if (host_->delegate() && host_->delegate()->GetInputEventRouter()) {
+ host_->delegate()->GetInputEventRouter()->RemoveSurfaceIdNamespaceOwner(
+ GetSurfaceIdNamespace());
}
}
-#endif
gfx::Rect RenderWidgetHostViewGuest::GetViewBounds() const {
if (!guest_)
@@ -538,32 +547,6 @@ void RenderWidgetHostViewGuest::DestroyGuestView() {
base::MessageLoop::current()->DeleteSoon(FROM_HERE, this);
}
-bool RenderWidgetHostViewGuest::CanDispatchToConsumer(
- ui::GestureConsumer* consumer) {
- CHECK_EQ(static_cast<RenderWidgetHostViewGuest*>(consumer), this);
- return true;
-}
-
-void RenderWidgetHostViewGuest::DispatchGestureEvent(
- ui::GestureEvent* event) {
- ForwardGestureEventToRenderer(event);
-}
-
-void RenderWidgetHostViewGuest::DispatchCancelTouchEvent(
- ui::TouchEvent* event) {
- if (!host_)
- return;
-
- blink::WebTouchEvent cancel_event;
- // TODO(rbyers): This event has no touches in it. Don't we need to know what
- // touches are currently active in order to cancel them all properly?
- WebTouchEventTraits::ResetType(blink::WebInputEvent::TouchCancel,
- event->time_stamp().InSecondsF(),
- &cancel_event);
-
- host_->ForwardTouchEventWithLatencyInfo(cancel_event, *event->latency());
-}
-
bool RenderWidgetHostViewGuest::ForwardGestureEventToRenderer(
ui::GestureEvent* gesture) {
#if defined(USE_AURA)

Powered by Google App Engine
This is Rietveld 408576698