src/DartARM32/assembler_arm.h - Issue 1412923006: Add orr (register) and orr (immediate) to ARM integrated assembler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/DartARM32/assembler_arm.h

Issue 1412923006: Add orr (register) and orr (immediate) to ARM integrated assembler. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Merge with master Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/DartARM32/assembler_arm.h

diff --git a/src/DartARM32/assembler_arm.h b/src/DartARM32/assembler_arm.h

index 46cba565e08e8c3493c24c2defe7d08922671bd9..cc8f6a3b89625596887613bb0df8a0fc97ac9e14 100644

--- a/src/DartARM32/assembler_arm.h

+++ b/src/DartARM32/assembler_arm.h

@@ -481,11 +481,12 @@ class Assembler : public ValueObject {

void cmn(Register rn, Operand o, Condition cond = AL);

+#if 0

+ // Moved to ARM32::IceAssemblerARM32::orr().

void orr(Register rd, Register rn, Operand o, Condition cond = AL);

void orrs(Register rd, Register rn, Operand o, Condition cond = AL);

-#if 0

- // Moved to IceAssemblerARM32::mov()

+ // Moved to ARM32::IceAssemblerARM32::mov()

void mov(Register rd, Operand o, Condition cond = AL);

void movs(Register rd, Operand o, Condition cond = AL);

#endif

« no previous file with comments | « no previous file | src/DartARM32/assembler_arm.cc » ('j') | no next file with comments »