content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 14129003: Fix the incorrect native ImeAdapter attach and detach.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 14129003: Fix the incorrect native ImeAdapter attach and detach. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: fix nits Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/ime_adapter_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 6d44e042af538f17c108e45c3c0b3dc3706ee2b3..f84f6e72981dfef106cd79bcb64fa3c51ffcc4f7 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -2214,6 +2214,14 @@ public class ContentViewCore implements MotionEventDelegate, NavigationClient {

}

+ @SuppressWarnings("unused")

+ @CalledByNative

+ private void onWebContentsSwapped() {

+ if (mImeAdapter != null && mNativeContentViewCore != 0) {

+ mImeAdapter.attach(nativeGetNativeImeAdapter(mNativeContentViewCore));

+ }

/**

* @return Whether a reload happens when this ContentView is activated.