chrome/common/extensions/docs/server2/template_data_source.py - Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/template_data_source.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/server_instance.py ('K') | « chrome/common/extensions/docs/server2/server_instance.py ('k') | chrome/common/extensions/docs/server2/test_data/file_system_stat/list/dir/stat » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/template_data_source.py

===================================================================

--- chrome/common/extensions/docs/server2/template_data_source.py (revision 197821)

+++ chrome/common/extensions/docs/server2/template_data_source.py (working copy)

@@ -51,7 +51,8 @@

compiled_fs_factory,

ref_resolver_factory,

public_template_path,

- private_template_path):

+ private_template_path,

+ base_path=None):

self._branch_info = _MakeChannelDict(channel_name)

self._api_data_source_factory = api_data_source_factory

self._api_list_data_source_factory = api_list_data_source_factory

@@ -63,7 +64,9 @@

self._ref_resolver = ref_resolver_factory.Create()

self._public_template_path = public_template_path

self._private_template_path = private_template_path

- self._static_resources = '/%s/static' % channel_name

+ if base_path is None:

+ base_path = '/%s/' % channel_name

+ self._static_resources = '%sstatic' % base_path

not at google - send to devlin 2013/05/03 19:12:22 Pass static resources through rather than base_pat

方觉(Fang Jue) 2013/05/04 02:05:41 Done.

def _CreateTemplate(self, template_name, text):

return Handlebar(self._ref_resolver.ResolveAllLinks(text))