chrome/common/extensions/docs/server2/render_servlet.py - Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/render_servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/docs/server2/patched_file_system_test.py ('K') | « chrome/common/extensions/docs/server2/patched_file_system_test.py ('k') | chrome/common/extensions/docs/server2/rietveld_patcher.py » ('j') | chrome/common/extensions/docs/server2/rietveld_patcher.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/render_servlet.py

===================================================================

--- chrome/common/extensions/docs/server2/render_servlet.py (revision 197821)

+++ chrome/common/extensions/docs/server2/render_servlet.py (working copy)

@@ -58,6 +58,9 @@

if channel is None:

channel = _DEFAULT_CHANNEL

+ base_path = '/'

+ else:

+ base_path = '/%s/' % channel

# AppEngine instances should never need to call out to SVN. That should

# only ever be done by the cronjobs, which then write the result into

@@ -77,7 +80,7 @@

# to run the cron before rendering things.

constructor = (ServerInstance.CreateOnline if _ALWAYS_ONLINE else

ServerInstance.GetOrCreateOffline)

- server_instance = constructor(channel)

+ server_instance = constructor(channel, base_path)

canonical_path = server_instance.path_canonicalizer.Canonicalize(path)

if path != canonical_path: