chrome/common/extensions/docs/server2/servlet.py - Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/docs/server2/servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/

Patch Set: add executable bits for tests Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/docs/server2/server_instance.py ('k') | chrome/common/extensions/docs/server2/template_data_source.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/docs/server2/servlet.py

diff --git a/chrome/common/extensions/docs/server2/servlet.py b/chrome/common/extensions/docs/server2/servlet.py

index 9618bbddb1fe0ffdaf3329a748063f515046d99f..f9af7447f0e64df91b08e2d324e9055ebb7c301c 100644

--- a/chrome/common/extensions/docs/server2/servlet.py

+++ b/chrome/common/extensions/docs/server2/servlet.py

@@ -100,6 +100,11 @@ class Response(object):

def SetStatus(self, status):

self.status = status

+ def GetRedirect(self):

+ if self.headers.get('Location') is None:

+ return (None, None)

+ return (self.headers.get('Location'), self.status == 301)

def __repr__(self):

return 'Response(content=%s bytes, status=%s, headers=%s entries)' % (

len(self.content), self.status, len(self.headers.keys()))