Docserver: Add support for viewing docs with a codereview patch applied

chrome/common/extensions/docs/server2/handler.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 from StringIO import StringIO
 import traceback
 
 from appengine_wrappers import (
     DeadlineExceededError, IsDevServer, logservice, memcache, urlfetch, webapp)
 from branch_utility import BranchUtility
+from rietveld_utility import RietveldUtility
 from server_instance import ServerInstance
 import svn_constants
 import time
 
 # The default channel to serve docs for if no channel is specified.
 _DEFAULT_CHANNEL = 'stable'
 
 class Handler(webapp.RequestHandler):
   # AppEngine instances should never need to call out to SVN. That should only
   # ever be done by the cronjobs, which then write the result into DataStore,
@@ skipping 10 matching lines @@
   #
   # However, we can't expect users of preview.py nor the dev server to run a
   # cronjob first, so, this is a hack allow that to be online all of the time.
   # TODO(kalman): achieve this via proper dependency injection.
   ALWAYS_ONLINE = IsDevServer()
 
   def __init__(self, request, response):
     super(Handler, self).__init__(request, response)
 
   def _HandleGet(self, path):
-    channel_name, real_path = BranchUtility.SplitChannelNameFromPath(path)
+    channel_name, issue, real_path = (

[not at google - send to devlin, 2013/04/26 23:53:53]

We only need to support 'trunk' here. Note for future.

[方觉(Fang Jue), 2013/04/27 00:24:34]

Yes. I know that. And SplitPatchFromPath will always return 'trunk' here.

[not at google - send to devlin, 2013/04/27 00:45:30]

Yep, as in when you pull this into its own servlet there won't need to be that
redundant channel_name variable.

+        RietveldUtility.SplitPatchFromPath(path))
+    if issue is None:
+      channel_name, real_path = BranchUtility.SplitChannelNameFromPath(path)

[not at google - send to devlin, 2013/04/26 23:53:53]

I've just written https://codereview.chromium.org/14273035/ to make this all a
more pluggable architecture. It's still a bit more intertwined than I'd like,
but that patch should be enough to get started with.

[方觉(Fang Jue), 2013/04/27 00:24:34]

I did take a look at it just now before I had breakfast. I'll update my patch
when that one is landed.

 
     if channel_name == _DEFAULT_CHANNEL:
       self.redirect('/%s' % real_path)
       return
 
     if channel_name is None:
       channel_name = _DEFAULT_CHANNEL
 
     # TODO(kalman): Check if |path| is a directory and serve path/index.html
     # rather than special-casing apps/extensions.
     if real_path.strip('/') == 'apps':
       real_path = 'apps/index.html'
     if real_path.strip('/') == 'extensions':
       real_path = 'extensions/index.html'
 
-    constructor = (
-        ServerInstance.CreateOnline if Handler.ALWAYS_ONLINE else
-        ServerInstance.GetOrCreateOffline)
-    server_instance = constructor(channel_name)
+    # Serving patched content requires an online server instance to fetch
+    # data from SVN and Rietveld.
+    if Handler.ALWAYS_ONLINE or issue is not None:
+      server_instance = ServerInstance.CreateOnline(channel_name, issue)
+    else:
+      server_instance = ServerInstance.GetOrCreateOffline(channel_name)
 
     canonical_path = server_instance.path_canonicalizer.Canonicalize(real_path)
     if real_path != canonical_path:
       self.redirect(canonical_path)
       return
 
     server_instance.Get(real_path, self.request, self.response)
 
   def _HandleCron(self, path):
     # Cron strategy:
@@ skipping 139 matching lines @@
     # file paths will know to treat this as a directory.
     if os.path.splitext(path)[1] == '' and path[-1] != '/':
       self.redirect(path + '/')
       return
 
     path = path.strip('/')
     if self._RedirectFromCodeDotGoogleDotCom(path):
       return
 
     self._HandleGet(path)