Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Side by Side Diff: chrome/common/extensions/docs/server2/patch_servlet.py

Issue 14125010: Docserver: Add support for viewing docs with a codereview patch applied (Closed) Base URL: https://src.chromium.org/svn/trunk/src/
Patch Set: add executable bits for tests Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 from appengine_url_fetcher import AppEngineUrlFetcher
6 from caching_file_system import CachingFileSystem
7 from caching_rietveld_patcher import CachingRietveldPatcher
8 from chained_compiled_file_system import ChainedCompiledFileSystem
9 from compiled_file_system import CompiledFileSystem
10 from instance_servlet import InstanceServlet
11 from render_servlet import RenderServlet
12 from rietveld_patcher import RietveldPatcher, RietveldPatcherError
13 from object_store_creator import ObjectStoreCreator
14 from patched_file_system import PatchedFileSystem
15 from server_instance import ServerInstance
16 from servlet import Request, Response, Servlet
17 import svn_constants
18 import url_constants
19
20 class _PatchServletDelegate(RenderServlet.Delegate):
21 def __init__(self, issue, delegate):
22 self._issue = issue
23 self._delegate = delegate
24
25 def CreateServerInstanceForChannel(self, channel):
26 base_object_store_creator = ObjectStoreCreator(channel,
27 start_empty=False)
28 # TODO(fj): Use OfflineFileSystem here once all json/idl files in api/
29 # are pulled into data store by cron jobs.
30 base_file_system = CachingFileSystem(
31 self._delegate.CreateHostFileSystemForBranch(channel),
32 base_object_store_creator)
33 base_compiled_fs_factory = CompiledFileSystem.Factory(
34 base_file_system, base_object_store_creator)
35
36 object_store_creator = ObjectStoreCreator('trunk@%s' % self._issue,
37 start_empty=False)
38 rietveld_patcher = CachingRietveldPatcher(
39 RietveldPatcher(svn_constants.EXTENSIONS_PATH,
40 self._issue,
41 AppEngineUrlFetcher(url_constants.CODEREVIEW_SERVER)),
42 object_store_creator)
43 patched_file_system = PatchedFileSystem(base_file_system,
44 rietveld_patcher)
45 patched_compiled_fs_factory = CompiledFileSystem.Factory(
46 patched_file_system, object_store_creator)
47
48 compiled_fs_factory = ChainedCompiledFileSystem.Factory(
49 [(patched_compiled_fs_factory, patched_file_system),
50 (base_compiled_fs_factory, base_file_system)])
51 return ServerInstance(channel,
52 object_store_creator,
53 patched_file_system,
54 self._delegate.CreateAppSamplesFileSystem(
55 object_store_creator),
56 '/_patch/%s/static' % self._issue,
57 compiled_fs_factory)
58
59 class PatchServlet(Servlet):
60 '''Servlet which renders patched docs.
61 '''
62 def __init__(self, request, delegate=None):
63 self._request = request
64 self._delegate = delegate or InstanceServlet.Delegate()
65
66 def Get(self):
67 path_with_issue = self._request.path.lstrip('/')
68 if '/' in path_with_issue:
69 issue, real_path = path_with_issue.split('/', 1)
70 else:
71 return Response.NotFound('Malformed URL. It should look like ' +
72 'https://developer.chrome.com/_patch/12345/extensions/...')
73
74 fake_path = '/trunk/%s' % real_path
75
76 try:
77 response = RenderServlet(
78 Request(fake_path, self._request.host, self._request.headers),
79 _PatchServletDelegate(issue, self._delegate)).Get()
80 # Disable cache for patched content.
81 response.headers.pop('cache-control', None)
82 except RietveldPatcherError as e:
83 response = Response.NotFound(e.message, {'Content-Type': 'text/plain'})
84
85 redirect_url, permanent = response.GetRedirect()
86 if redirect_url is not None:
87 if redirect_url.startswith('/trunk/'):
88 redirect_url = redirect_url.split('/trunk', 1)[1]
89 response = Response.Redirect('/_patch/%s%s' % (issue, redirect_url),
90 permanent)
91 return response
OLDNEW
« no previous file with comments | « chrome/common/extensions/docs/server2/instance_servlet.py ('k') | chrome/common/extensions/docs/server2/patch_servlet_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698