Docserver: Add support for viewing docs with a codereview patch applied

chrome/common/extensions/docs/server2/server_instance.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from fnmatch import fnmatch
 import logging
 import mimetypes
 import traceback
 import os
 
@@ skipping 21 matching lines @@
 from template_data_source import TemplateDataSource
 from test_object_store import TestObjectStore
 from third_party.json_schema_compiler.model import UnixName
 import url_constants
 
 class ServerInstance(object):
   def __init__(self,
                channel,
                object_store_creator,
                host_file_system,
-               app_samples_file_system):
+               app_samples_file_system,
+               static_path=None,
+               compiled_fs_factory=None):

[not at google - send to devlin, 2013/05/11 20:39:53]

having these as optional parameters doesn't gain much, there are only a few
places where ServerInstances are constructed, and I prefer to be explicit rather
than have too many optional parameters.

     self.channel = channel
 
     self.object_store_creator = object_store_creator
 
     self.host_file_system = host_file_system
 
     self.app_samples_file_system = app_samples_file_system
 
-    self.compiled_host_fs_factory = CompiledFileSystem.Factory(
-        host_file_system,
-        object_store_creator)
+    if compiled_fs_factory is None:
+      self.compiled_host_fs_factory = CompiledFileSystem.Factory(
+          host_file_system,
+          object_store_creator)
+    else:
+      self.compiled_host_fs_factory = compiled_fs_factory
 
     self.api_list_data_source_factory = APIListDataSource.Factory(
         self.compiled_host_fs_factory,
         svn_constants.API_PATH,
         svn_constants.PUBLIC_TEMPLATE_PATH)
 
     self.api_data_source_factory = APIDataSource.Factory(
         self.compiled_host_fs_factory,
         svn_constants.API_PATH)
 
@@ skipping 26 matching lines @@
 
     self.intro_data_source_factory = IntroDataSource.Factory(
         self.compiled_host_fs_factory,
         self.ref_resolver_factory,
         [svn_constants.INTRO_PATH, svn_constants.ARTICLE_PATH])
 
     self.sidenav_data_source_factory = SidenavDataSource.Factory(
         self.compiled_host_fs_factory,
         svn_constants.JSON_PATH)
 
+    if static_path is None:
+      static_path = '/static' if channel == 'stable' else '/%s/static' % channel
     self.template_data_source_factory = TemplateDataSource.Factory(
         channel,
         self.api_data_source_factory,
         self.api_list_data_source_factory,
         self.intro_data_source_factory,
         self.samples_data_source_factory,
         self.sidenav_data_source_factory,
         self.compiled_host_fs_factory,
         self.ref_resolver_factory,
         svn_constants.PUBLIC_TEMPLATE_PATH,
-        svn_constants.PRIVATE_TEMPLATE_PATH)
+        svn_constants.PRIVATE_TEMPLATE_PATH,
+        static_path)
 
     self.example_zipper = ExampleZipper(
         self.compiled_host_fs_factory,
         svn_constants.DOCS_PATH)
 
     self.path_canonicalizer = PathCanonicalizer(
         channel,
         self.compiled_host_fs_factory)
 
     self.content_cache = self.compiled_host_fs_factory.CreateIdentity(
@@ skipping 10 matching lines @@
   def ForLocal():
     channel = 'trunk'
     object_store_creator = ObjectStoreCreator(channel,
                                               start_empty=False,
                                               store_type=TestObjectStore)
     return ServerInstance(
         channel,
         object_store_creator,
         CachingFileSystem(LocalFileSystem.Create(), object_store_creator),
         EmptyDirFileSystem())