Issue 14121006: ARM: Small copy optimization. Copying 64bits at a time.

Issue 14121006: ARM: Small copy optimization. Copying 64bits at a time. (Closed)

Created:
7 years, 8 months ago by Rodolph Perfetta

Modified:
7 years, 8 months ago

Reviewers:
ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: Small copy optimization. Copying 64bits at a time. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=14254

Patch Set 1 #

Total comments: 5

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -34 lines)			Patch
M	src/arm/assembler-arm.h	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/full-codegen-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1 chunk	+2 lines, -11 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	1 chunk	+13 lines, -20 lines	5 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM with nits. https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.cc#newcode3164 src/arm/macro-assembler-arm.cc:3164: SwVfpRegister single_scratch, Can we implicitly use ...

7 years, 8 months ago (2013-04-12 14:07:04 UTC) #2

Rodolph Perfetta

https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.cc#newcode3164 src/arm/macro-assembler-arm.cc:3164: SwVfpRegister single_scratch, not all double registers have a low ...

7 years, 8 months ago (2013-04-12 14:42:59 UTC) #3

ulan

7 years, 8 months ago (2013-04-15 07:44:06 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/14121006/diff/1/src/arm/macro-assembler-arm.c...
src/arm/macro-assembler-arm.cc:3164: SwVfpRegister single_scratch,
On 2013/04/12 14:42:59, Rodolph Perfetta wrote:
> not all double registers have a low (or high), only d0-d15 have them.
> 
I see, thanks for clarification!

Expand Messages | Collapse Messages