Issue 14121004: ARM: VFP tweaks/optimisations. Further address slow FPSCR accesses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14121004: ARM: VFP tweaks/optimisations. Further address slow FPSCR accesses. (Closed)

Created:
7 years, 8 months ago by Rodolph Perfetta

Modified:
7 years, 8 months ago

Reviewers:
hans, ulan, danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM: VFP tweaks/optimisations. Further address slow FPSCR accesses. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=14311

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -28 lines)			Patch
	M	src/arm/lithium-codegen-arm.cc	View		4 chunks	+31 lines, -28 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

https://codereview.chromium.org/14121004/diff/1/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): https://codereview.chromium.org/14121004/diff/1/src/arm/lithium-codegen-arm.cc#newcode2109 src/arm/lithium-codegen-arm.cc:2109: if (!left_reg.is(result_reg)) { Why do we need this "if" ...

7 years, 8 months ago (2013-04-17 14:30:40 UTC) #2

ulan

7 years, 8 months ago (2013-04-17 14:45:46 UTC) #3

> If left_reg is result_reg, "Move(result_reg, left_reg);" won't generate any
code. So, it's no use to do a jump over nothing.
I see, thanks. LGTM.

Expand Messages | Collapse Messages