Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 14120009: Add a command line parameter to disable online EULA. (Closed)

Created:
7 years, 8 months ago by vasilii
Modified:
7 years, 8 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

New command line parameter --disable-cros-online-eula disables online EULA on CrOS. The static localized version is shown instead. URLFetcher is explicitly asked to avoid cache and cookies while fetching the online EULA. BUG=174271 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196113

Patch Set 1 : a flag and NO_COOKIE options #

Total comments: 1

Patch Set 2 : Addressed nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M chrome/browser/ui/webui/about_ui.cc View 1 4 chunks +11 lines, -0 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
vasilii
Hi, Please review the CL. Dominic, Nikita: * Evan: about_ui.cc Mitsuru: chromeos_switches
7 years, 8 months ago (2013-04-22 12:48:56 UTC) #1
Nikita (slow)
On 2013/04/22 12:48:56, vasilii wrote: > Mitsuru: chromeos_switches You don't need a separate owners review ...
7 years, 8 months ago (2013-04-22 15:48:29 UTC) #2
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-22 15:48:53 UTC) #3
battre
lgtm
7 years, 8 months ago (2013-04-22 16:43:05 UTC) #4
oshima
On 2013/04/22 15:48:29, Nikita Kostylev wrote: > On 2013/04/22 12:48:56, vasilii wrote: > > Mitsuru: ...
7 years, 8 months ago (2013-04-22 17:33:41 UTC) #5
vasilii
Evan?
7 years, 8 months ago (2013-04-23 07:26:21 UTC) #6
Evan Stade
lgtm with nit https://codereview.chromium.org/14120009/diff/2001/chrome/browser/ui/webui/about_ui.cc File chrome/browser/ui/webui/about_ui.cc (right): https://codereview.chromium.org/14120009/diff/2001/chrome/browser/ui/webui/about_ui.cc#newcode249 chrome/browser/ui/webui/about_ui.cc:249: } else { this looks equivalent ...
7 years, 8 months ago (2013-04-23 18:50:05 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vasilii@chromium.org/14120009/14001
7 years, 8 months ago (2013-04-24 07:36:38 UTC) #8
commit-bot: I haz the power
7 years, 8 months ago (2013-04-24 10:40:42 UTC) #9
Message was sent while issue was closed.
Change committed as 196113

Powered by Google App Engine
This is Rietveld 408576698