Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 14119009: Revert "Revert 193798 "Revert r192949 "Disable shader disk cache by defa..."" (Closed)

Created:
7 years, 8 months ago by dsinclair
Modified:
7 years, 7 months ago
Reviewers:
groby-ooo-7-16, tonyg
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert "Revert 193798 "Revert r192949 "Disable shader disk cache by defa..."" The automation_proxy don't appear in the build run where this was committed. Doesn't seem like this is the root cause of the issues. > Revert 193798 "Revert r192949 "Disable shader disk cache by defa..." > > Reverting seems to fix memory_test test locally on linux. > > BUG=230085 > > > Revert r192949 "Disable shader disk cache by default." > > > > This reverts commit r192949. The disable has been merged into > > M27 so re-enabling on trunk. > > > > BUG=228989 > > > > Review URL: https://chromiumcodereview.appspot.com/13872012 > > TBR=dsinclair@chromium.org > > Review URL: https://codereview.chromium.org/13924005 TBR=tonyg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195083

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -10 lines) Patch
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/gpu_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_switches.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/memory_program_cache_unittest.cc View 4 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14119009/1
7 years, 8 months ago (2013-04-18 19:57:14 UTC) #1
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=30370
7 years, 8 months ago (2013-04-18 23:52:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dsinclair@chromium.org/14119009/1
7 years, 8 months ago (2013-04-19 00:43:36 UTC) #3
commit-bot: I haz the power
Change committed as 195083
7 years, 8 months ago (2013-04-19 03:51:02 UTC) #4
groby-ooo-7-16
7 years, 7 months ago (2013-05-08 20:23:24 UTC) #5
Message was sent while issue was closed.
This brought the memory issues back, WebKit Valgrind only. 

See e.g.
http://build.chromium.org/p/chromium.memory.fyi/builders/Webkit%20Linux%20%28...

Will file bug & suppression, just a heads-up

Powered by Google App Engine
This is Rietveld 408576698